Bug 479788 - Sequence effect lost after saving
Summary: Sequence effect lost after saving
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Video Effects & Transitions (show other bugs)
Version: 23.08.4
Platform: Flatpak Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-14 06:27 UTC by red_Arti
Modified: 2024-01-16 20:46 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screen-record (274.43 KB, video/mp4)
2024-01-14 06:27 UTC, red_Arti
Details

Note You need to log in before you can comment on or make changes to this bug.
Description red_Arti 2024-01-14 06:27:43 UTC
Created attachment 164894 [details]
screen-record

SUMMARY
Sequence effect lost after saving
(See attachment for screen record video)

STEPS TO REPRODUCE
1. Create project
2. Add p1.jpg to project
3. Add an effect (eg emboss) to p1.jpg
4. Add an effect (eg grow) to Sequence 1
Now both p1.jpg and Sequence 1 have effect icon
5. Save project

OBSERVED RESULT
After saving, the effect on Sequence 1 lost.
See only p1.jpg has effect icon.

EXPECTED RESULT
Effect on Sequence 1 should be correctly saved

SOFTWARE/OS VERSIONS
Kdenlive 23.08.04 Flatpak
KDE Frameworks Version 5.112.0
Qt Version 5.15.10 (built against 5.15.10)

ADDITIONAL INFORMATION
Comment 1 Jean-Baptiste Mardelle 2024-01-14 10:02:38 UTC
Thanks for the report. Still happening on git master, working on a fix
Comment 2 Jean-Baptiste Mardelle 2024-01-14 11:06:59 UTC
Git commit 7c49766b45127af863112b8ff61e3a5be6668dbf by Jean-Baptiste Mardelle.
Committed on 14/01/2024 at 12:06.
Pushed by mardelle into branch 'release/24.02'.

Fix sequence effects lost

M  +4    -1    src/bin/projectclip.cpp
M  +1    -1    src/bin/projectclip.h
M  +6    -0    src/bin/projectitemmodel.cpp
M  +2    -0    src/bin/projectitemmodel.h
M  +4    -1    src/mltcontroller/clipcontroller.cpp
M  +7    -3    src/project/projectmanager.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/7c49766b45127af863112b8ff61e3a5be6668dbf
Comment 3 Jean-Baptiste Mardelle 2024-01-15 12:09:39 UTC
Git commit ee873cf885b618e67b56c71fc06295040a87e709 by Jean-Baptiste Mardelle.
Committed on 15/01/2024 at 13:09.
Pushed by mardelle into branch 'release/24.02'.

Add test for recent sequence effect bug

M  +0    -8    src/bin/bin.cpp
M  +0    -2    src/bin/bin.h
M  +7    -0    src/bin/projectitemmodel.cpp
M  +2    -0    src/bin/projectitemmodel.h
M  +1    -1    src/core.cpp
M  +5    -0    src/project/projectmanager.cpp
M  +118  -0    tests/nestingtest.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/ee873cf885b618e67b56c71fc06295040a87e709
Comment 4 Jean-Baptiste Mardelle 2024-01-16 20:46:40 UTC
Git commit 1b9dd950718959e0608682d3c8ff65abd2c8a717 by Jean-Baptiste Mardelle.
Committed on 16/01/2024 at 21:41.
Pushed by mardelle into branch 'release/23.08'.

Fix sequence effects lost

M  +4    -1    src/bin/projectclip.cpp
M  +1    -1    src/bin/projectclip.h
M  +6    -0    src/bin/projectitemmodel.cpp
M  +2    -0    src/bin/projectitemmodel.h
M  +4    -1    src/mltcontroller/clipcontroller.cpp
M  +7    -3    src/project/projectmanager.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/1b9dd950718959e0608682d3c8ff65abd2c8a717