Bug 479773 - improve handling "new" online quote source
Summary: improve handling "new" online quote source
Alias: None
Product: libalkimia
Classification: Frameworks and Libraries
Component: Online Quotes Editor (show other bugs)
Version: master
Platform: Compiled Sources All
: NOR wishlist
Target Milestone: 8.2
Assignee: KMyMoney Devel Mailing List
Depends on:
Reported: 2024-01-13 22:35 UTC by Jack
Modified: 2024-01-14 12:09 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 8.1.73


Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2024-01-13 22:35:42 UTC
If you bring up the Online Quotes configuration dialog, the "New" button is disabled if there is a source called "New Quote Source."   As this is the name given to a new source created when you click the "New" button, it is quite possible (it just happened to me) to bring up the dialog, wanting to create a new source, and find the "New" button disabled, having forgotten you once clicked that button, but never finished (or even started) configuring the new source (as part of which it should have been renamed.  There are enough existing sources that "New Quote Source" can simply get lost in the list.

Proposal:  Do not disable the "New" button if there is a source called "New Quote Source."  Instead, when the "New" button is clicked, just select "New Quote Source" if it already exists.  Perhaps, in that case, it would also be reasonable to show a pop-up notifying the user that a "New Quote Source" had already been created, and it should be renamed, if another new source was actually desired.
Comment 1 Thomas Baumgart 2024-01-14 12:06:45 UTC
Moved to libalkimia since we will replace the KMyMoney specific logic with the one provided by Alkimia.
Comment 2 Thomas Baumgart 2024-01-14 12:09:43 UTC
Git commit e0abae2c4c741dd390636915f7ddd42b1201ec50 by Thomas Baumgart.
Committed on 14/01/2024 at 13:09.
Pushed by tbaumgart into branch 'master'.

Keep new quote source button enabled

The new quote source button is kept enabled in case the widget is not in
read-only mode. If pressed and an item with name "New Quote Source"
already exists, it is selected and made visible in the combo box.

For Qt5 and above an additional message is displayed, that the item
already exists.
FIXED-IN: 8.1.73

M  +2    -2    src/alkonlinequotes.ui
M  +34   -6    src/alkonlinequoteswidget.cpp