Bug 479752 - Panel Settings: preview of Opacity→Adaptive setting has incorrect panel corner radius
Summary: Panel Settings: preview of Opacity→Adaptive setting has incorrect panel corne...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: master
Platform: Neon Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2024-01-13 17:01 UTC by fin-w
Modified: 2024-01-17 17:45 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0
Sentry Crash Report:


Attachments
The Panel Settings open with "Adaptive" opacity selected, showing a preview with a panel that has a small corner radius. (776.82 KB, image/png)
2024-01-13 17:01 UTC, fin-w
Details

Note You need to log in before you can comment on or make changes to this bug.
Description fin-w 2024-01-13 17:01:13 UTC
Created attachment 164871 [details]
The Panel Settings open with "Adaptive" opacity selected, showing a preview with a panel that has a small corner radius.

SUMMARY
The new design of the Panel Settings has a grid of six preview images that indicate current settings for the panel. The Opacity setting shows a preview of a panel either opaque or translucent, or adaptive. The adaptive panel in the preview has the wrong size border radius when compared to the panels displayed in the other previews within Panel Settings.

STEPS TO REPRODUCE
1. Open Panel Settings
2. Set Style→Floating (I'm not sure if it happens with non-floating panels)
3. Select Opacity→Adaptive

OBSERVED RESULT
The Adaptive panel in the preview under the Opacity heading has a very small corner radius, which is different to all five other panels in the previews.

EXPECTED RESULT
The Adaptive panel in the preview under the Opacity heading displays with the same corner radius as all the other panels in the previews. 

SOFTWARE/OS VERSIONS
(Latest KDE Neon Unstable, updated today)
KDE Plasma Version: 5.91.90
KDE Frameworks Version: 5.248.0
Qt Version: 6.6.1
Comment 1 Nate Graham 2024-01-17 00:39:14 UTC
Can confirm.
Comment 2 Nate Graham 2024-01-17 00:54:57 UTC
According to a comment in the code, this is intentional, to work around a technical bug. However, removing the workaround now, I see no issue, so it's possible that it works fine in Qt 6 now. I'll submit a merge request.
Comment 3 Bug Janitor Service 2024-01-17 00:57:02 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1979
Comment 4 Nate Graham 2024-01-17 17:38:43 UTC
Git commit 5a89f866743ebf5bbb89919950ad20bf4e8b520b by Nate Graham.
Committed on 17/01/2024 at 15:52.
Pushed by ngraham into branch 'master'.

panelconfiguration: use standard border radius for Adaptive preview

Apparently this didn't work in the past due to technical bugs with the
clipping, but none of those issues appear to be present at the moment.
Seems like it was fixed upstream in Qt6.
FIXED-IN: 6.0

M  +1    -1    desktoppackage/contents/configuration/panelconfiguration/PanelRepresentation.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/5a89f866743ebf5bbb89919950ad20bf4e8b520b
Comment 5 Nate Graham 2024-01-17 17:45:03 UTC
Git commit 42c86769a78c6d6dada0b5d68eb87a530d6cb335 by Nate Graham.
Committed on 17/01/2024 at 18:45.
Pushed by ngraham into branch 'Plasma/6.0'.

panelconfiguration: use standard border radius for Adaptive preview

Apparently this didn't work in the past due to technical bugs with the
clipping, but none of those issues appear to be present at the moment.
Seems like it was fixed upstream in Qt6.
FIXED-IN: 6.0


(cherry picked from commit 5a89f866743ebf5bbb89919950ad20bf4e8b520b)

M  +1    -1    desktoppackage/contents/configuration/panelconfiguration/PanelRepresentation.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/42c86769a78c6d6dada0b5d68eb87a530d6cb335