Bug 479573 - Horizontal bars don't allow setting data CPU temp range or can't automatically find it
Summary: Horizontal bars don't allow setting data CPU temp range or can't automaticall...
Status: RESOLVED FIXED
Alias: None
Product: plasma-systemmonitor
Classification: Applications
Component: general (show other bugs)
Version: 5.27.10
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
: 451157 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-01-09 12:59 UTC by PRamos
Modified: 2024-02-09 00:44 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0


Attachments
Screenshot of the new widget (25.22 KB, image/png)
2024-01-09 12:59 UTC, PRamos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description PRamos 2024-01-09 12:59:24 UTC
Created attachment 164776 [details]
Screenshot of the new widget

SUMMARY
***
It seems after some update the automatic maximum range for CPU temperature was lost, meaning the horizontal bar widget is permanently displayed as full.
The widget was working correctly on my machine as of last september, but it seems some update either to the way the maximum temperature is obtained or to the widget left the issue behind.
***


STEPS TO REPRODUCE
1. Add a system monitor widget
2. Set it to the Horizontal Bars Display Style
3. Set the Sensor to Average CPU Temperature

OBSERVED RESULT
The bar is always full, even when the CPU is only at 40ºC or so.

EXPECTED RESULT
Previously, the bar would fill only when hitting over 100ºC.
I noticed other display styles have the option to set the range manually (which works), but however Horizontal Bars do not.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 6.6.8-2-MANJARO
KDE Plasma Version:  Plasma 5.27.10
KDE Frameworks Version: 5.113.0
Qt Version: 5.15.11

ADDITIONAL INFORMATION
CPU: AMD Ryzen 7 5700U
Comment 1 Arjen Hiemstra 2024-02-02 14:47:31 UTC
*** Bug 451157 has been marked as a duplicate of this bug. ***
Comment 2 Bug Janitor Service 2024-02-06 10:44:56 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libksysguard/-/merge_requests/318
Comment 3 Arjen Hiemstra 2024-02-07 11:18:51 UTC
Git commit 6b3b16c44b642239995ef2d8be0b2872b9aa18e7 by Arjen Hiemstra.
Committed on 07/02/2024 at 11:17.
Pushed by ahiemstra into branch 'master'.

faces/horizontalbars: Allow specifying the data range from config

In some cases, we may want to display sensors using this face that don't
have a proper min/max range. So add the same sort of configuration that
we have for other faces so it becomes possible to override the automatic
data range with a manually specified one.

While at it, port the actual bar implementation from a manual
implementation to a ProgressBar with overridden contentItem, as that
makes the code a fair bit easier to work with.

A  +32   -0    faces/facepackages/horizontalbars/contents/config/main.xml
M  +24   -18   faces/facepackages/horizontalbars/contents/ui/Bar.qml
A  +45   -0    faces/facepackages/horizontalbars/contents/ui/Config.qml     [License: LGPL(v2.0+)]
M  +3    -1    faces/facepackages/horizontalbars/contents/ui/FullRepresentation.qml

https://invent.kde.org/plasma/libksysguard/-/commit/6b3b16c44b642239995ef2d8be0b2872b9aa18e7
Comment 4 Arjen Hiemstra 2024-02-07 12:09:47 UTC
Git commit 370b874a80b06bf8f39edb0052fb2d93bd09d428 by Arjen Hiemstra.
Committed on 07/02/2024 at 12:07.
Pushed by ahiemstra into branch 'Plasma/6.0'.

faces/horizontalbars: Allow specifying the data range from config

In some cases, we may want to display sensors using this face that don't
have a proper min/max range. So add the same sort of configuration that
we have for other faces so it becomes possible to override the automatic
data range with a manually specified one.

While at it, port the actual bar implementation from a manual
implementation to a ProgressBar with overridden contentItem, as that
makes the code a fair bit easier to work with.


(cherry picked from commit 6b3b16c44b642239995ef2d8be0b2872b9aa18e7)

A  +32   -0    faces/facepackages/horizontalbars/contents/config/main.xml
M  +24   -18   faces/facepackages/horizontalbars/contents/ui/Bar.qml
A  +45   -0    faces/facepackages/horizontalbars/contents/ui/Config.qml     [License: LGPL(v2.0+)]
M  +3    -1    faces/facepackages/horizontalbars/contents/ui/FullRepresentation.qml

https://invent.kde.org/plasma/libksysguard/-/commit/370b874a80b06bf8f39edb0052fb2d93bd09d428