Bug 479287 - Selection box around application entries without a description is slightly taller
Summary: Selection box around application entries without a description is slightly ta...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) widget (other bugs)
Version First Reported In: 5.27.10
Platform: Neon Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-02 03:47 UTC by Joel H.
Modified: 2024-01-19 19:10 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 6.0
Sentry Crash Report:


Attachments
Edited screenshot showing entries side-by-side (1.09 MB, image/png)
2024-01-02 03:47 UTC, Joel H.
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joel H. 2024-01-02 03:47:25 UTC
Created attachment 164614 [details]
Edited screenshot showing entries side-by-side

The selection box around an application entry in list mode is slightly taller if no description subtext is rendered. I first noticed this on Plasma 6 Beta 2 via the latest Neon Unstable boot image, but this appears to affect at least as far back as 5.27.10 as well. 


STEPS TO REPRODUCE
1. Open the kickoff menu in it's default list mode with compact mode turned OFF
2. Compare the selection size of an application with no description subtext with one that has it

OBSERVED RESULT
Box selections do not match in size

EXPECTED RESULT
I expect the selection box around an application entry with no description showing to be the same size as one that does have a description.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.91.90
KDE Frameworks Version: 5.248.0
Qt Version: 6.6.1

ADDITIONAL INFORMATION
I have attached an edited screenshot to show this size difference.
This affects 5.27.10 on Arch Linux as well.
The screenshot has font size increased, but this does seem to affect normal sized fonts as well.
I can also reproduce this design error on Arch Linux running Plasma 5.27.10
Comment 1 Bug Janitor Service 2024-01-19 04:39:12 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1983
Comment 2 Nate Graham 2024-01-19 19:10:07 UTC
Git commit c4d4d0e4529638bc752c88688af28b8152a851b0 by Nate Graham.
Committed on 19/01/2024 at 05:34.
Pushed by ngraham into branch 'master'.

applets/kickoff: make list delegate heights consistent

When the description label is not present, the title label increases
its implicit height to attempt to match it so that all list delegates
have the same height. However it was using a faulty calculation by
simply doubling its own implicitHeight. This would have worked if both
labels had the same height, but they don't: the description label uses
the small font, so it's shorter.

We can fix this by using the description label's actual height instead
of approximating it incorrectly.
FIXED-IN: 6.0

M  +1    -1    applets/kickoff/package/contents/ui/KickoffListDelegate.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/c4d4d0e4529638bc752c88688af28b8152a851b0
Comment 3 Nate Graham 2024-01-19 19:10:25 UTC
Git commit 91c7f3cc33f5c630af22c67798e30956b0eac3d7 by Nate Graham.
Committed on 19/01/2024 at 20:10.
Pushed by ngraham into branch 'Plasma/6.0'.

applets/kickoff: make list delegate heights consistent

When the description label is not present, the title label increases
its implicit height to attempt to match it so that all list delegates
have the same height. However it was using a faulty calculation by
simply doubling its own implicitHeight. This would have worked if both
labels had the same height, but they don't: the description label uses
the small font, so it's shorter.

We can fix this by using the description label's actual height instead
of approximating it incorrectly.
FIXED-IN: 6.0


(cherry picked from commit c4d4d0e4529638bc752c88688af28b8152a851b0)

M  +1    -1    applets/kickoff/package/contents/ui/KickoffListDelegate.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/91c7f3cc33f5c630af22c67798e30956b0eac3d7