Bug 479084 - Standalone "Peek at Desktop", "Minimize all", and "Keyboard Layout" widgets inappropriately transfer focus to their parent Panel when activated
Summary: Standalone "Peek at Desktop", "Minimize all", and "Keyboard Layout" widgets i...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Show Desktop/Minimize All (show other bugs)
Version: master
Platform: Arch Linux Linux
: HI normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression, usability
: 482058 482653 483235 483928 484339 484417 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-12-27 16:51 UTC by Fernando M. Muniz
Modified: 2024-04-21 14:39 UTC (History)
14 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.3
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fernando M. Muniz 2023-12-27 16:51:22 UTC
This is might be just a setting I am not finding;
The “Peek Desktop” button on the corner of the taskbar, when clicked show the desktop as intended, however, it doesn’t transfer the focus/interactivity into the desktop, which is kind of annoying when trying to select files with the keyboard after clicking the “Peek Desktop” button, which result in sorting the taskbar icons, instead of the desktop files and folders.

Or to simplify: I need the “Peek Desktop” button to also minimize the taskbar itself, so i can navigate the Desktop files/folders.
Comment 1 Fernando M. Muniz 2024-01-08 18:59:36 UTC
The same issue happens when minimizing all windows in front of the desktop, then trying to interact with the files by moving your arrow keys.
The desktop should be the active area when it's the only area showing.
Comment 2 Nate Graham 2024-02-15 05:34:10 UTC
Confirmed. It would be nice if clicking on it transferred focus to the desktop, yeah.
Comment 3 Fernando M. Muniz 2024-02-15 16:27:22 UTC
Should i file another bug for the same issue when manually minimizing all windows to show the desktop?
Comment 4 Nate Graham 2024-02-15 16:29:04 UTC
Nah, internally the widgets share most of their code, so let's cover both here.
Comment 5 Fernando M. Muniz 2024-03-01 00:41:07 UTC
Updated the system info into the one that I currently have. (Same issue still happens)
Comment 6 comradeferret 2024-03-08 19:20:10 UTC
Problematic for folks who have unminimizable windows in the background that they use this widget as a shortcut for.  Worked fine in 5.
Comment 7 Bug Janitor Service 2024-03-10 21:26:00 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2110
Comment 8 Nate Graham 2024-03-11 17:56:36 UTC
Git commit 5909ac488df5fa469174387be4bb1ffe23578d0a by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 11/03/2024 at 17:56.
Pushed by ngraham into branch 'master'.

Panel: Don't take keyboard focus when one of its widgets is activated

This re-introduces the workaround that was removed by Marco in `6a61a56bcd`
Related: bug 482653
FIXED-IN: 6.0.2

M  +4    -1    desktoppackage/contents/views/Panel.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/5909ac488df5fa469174387be4bb1ffe23578d0a
Comment 9 Nate Graham 2024-03-11 18:07:18 UTC
Git commit a98f5f84098723a8c0dffeeb4de75f6f240a3671 by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 11/03/2024 at 17:57.
Pushed by ngraham into branch 'Plasma/6.0'.

Panel: Don't take keyboard focus when one of its widgets is activated

This re-introduces the workaround that was removed by Marco in `6a61a56bcd`
Related: bug 482653
FIXED-IN: 6.0.2


(cherry picked from commit 5909ac488df5fa469174387be4bb1ffe23578d0a)

3bfe5033 Do not give panel keyboard focus when an applet is activated

M  +4    -1    desktoppackage/contents/views/Panel.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/a98f5f84098723a8c0dffeeb4de75f6f240a3671
Comment 10 Nate Graham 2024-03-19 18:50:41 UTC
*** Bug 482653 has been marked as a duplicate of this bug. ***
Comment 11 Nate Graham 2024-03-19 18:50:51 UTC
*** Bug 482058 has been marked as a duplicate of this bug. ***
Comment 12 Nate Graham 2024-03-19 18:50:55 UTC
*** Bug 483235 has been marked as a duplicate of this bug. ***
Comment 13 Nate Graham 2024-03-19 18:51:57 UTC
Re-opening as we have multiple reports of this still happening in Plasma 6.0.2, on both X11 and Wayland. I still can't reproduce those issues unfortunately.
Comment 14 Nate Graham 2024-03-19 18:52:24 UTC
*** Bug 483928 has been marked as a duplicate of this bug. ***
Comment 15 Hanabishi 2024-03-19 20:02:22 UTC
I noticed that all reporters use Arch btw. So much at this point it does not look like a coincedence.
Comment 16 Niccolò Venerandi 2024-03-21 11:22:05 UTC
I checked just for sure that Arch packaged the fix correctly and they do, so it's most likely a coincidence (or, rather, most new Plasma 6 users are from Arch).
Comment 17 Edip 2024-03-21 11:51:38 UTC
(In reply to Hanabishi from comment #15)
> I noticed that all reporters use Arch btw. So much at this point it does not
> look like a coincedence.

Someone reproduced it on opensuse tumbleweed and neon testing, it's not from arch only
Comment 18 Hanabishi 2024-03-21 12:24:50 UTC
Ok, I just pointed out the pattern. But yeah, it explains simply by most early adopters being from Arch.
Comment 19 Bug Janitor Service 2024-03-22 07:33:28 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/libplasma/-/merge_requests/1082
Comment 20 Niccolò Venerandi 2024-03-24 09:30:33 UTC
*** Bug 484339 has been marked as a duplicate of this bug. ***
Comment 21 Michał Dybczak 2024-03-24 17:43:00 UTC
I've seen the commits pushed to 6.0.2 and yet the bug is still present in 6.0.3. Am I missing something?
I can reproduce the bug at any time 100% reliably.
Comment 22 Niccolò Venerandi 2024-03-25 13:09:40 UTC
(In reply to Michał Dybczak from comment #21)
> I've seen the commits pushed to 6.0.2 and yet the bug is still present in
> 6.0.3. Am I missing something?
> I can reproduce the bug at any time 100% reliably.

The bugfix is accidentally missing from 6.0 where it should've been, but since it also caused some other issues we're investigating a better approach directly
Comment 23 Niccolò Venerandi 2024-03-25 13:10:01 UTC
*** Bug 484417 has been marked as a duplicate of this bug. ***
Comment 24 Nate Graham 2024-03-25 19:05:32 UTC
Git commit 6794ae6ab7c2c50f5ac57d7f32f5db1f7347201c by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 25/03/2024 at 19:05.
Pushed by ngraham into branch 'master'.

Do not activate containment when one of its applet is activated

Reasoning is that some applets use "activated" when they would to trigger
their action, e.g. the show desktop applet. If the containment (here, the
panel) also gets activated as a result, it will get mouse input and a blue
line will appear. Previously this was avoided by some hacky code that (a)
apparently was not working for some people and (b) broke auto-hide and
dodge windows after clicking on "Minimize all".

This will also allow us to delete the hack in plasma-desktop.
Related: bug 483941
FIXED-IN: 6.0.3

M  +0    -4    src/plasma/containment.cpp

https://invent.kde.org/plasma/libplasma/-/commit/6794ae6ab7c2c50f5ac57d7f32f5db1f7347201c
Comment 25 Nate Graham 2024-03-25 19:06:27 UTC
Git commit 6203530a48a46e276d8e59452d23861118c1e362 by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 25/03/2024 at 19:06.
Pushed by ngraham into branch 'master'.

Revert "Panel: Don't take keyboard focus when one of its widgets is activated"

This reverts commit 5909ac488df5fa469174387be4bb1ffe23578d0a.

This is a companion to
https://invent.kde.org/plasma/libplasma/-/merge_requests/1082, which
removes need for this hack
Related: bug 483941

M  +1    -4    desktoppackage/contents/views/Panel.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/6203530a48a46e276d8e59452d23861118c1e362
Comment 26 Bug Janitor Service 2024-03-25 19:08:04 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/2143
Comment 27 Nate Graham 2024-03-25 19:14:57 UTC
Git commit e53fd6b066d569ae8247e5565c51560ace7af078 by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 25/03/2024 at 19:06.
Pushed by ngraham into branch 'Plasma/6.0'.

Revert "Panel: Don't take keyboard focus when one of its widgets is activated"

This reverts commit 5909ac488df5fa469174387be4bb1ffe23578d0a.

This is a companion to
https://invent.kde.org/plasma/libplasma/-/merge_requests/1082, which
removes need for this hack
Related: bug 483941


(cherry picked from commit 6203530a48a46e276d8e59452d23861118c1e362)

c2994876 Revert "Panel: Don't take keyboard focus when one of its widgets is activated"

M  +1    -4    desktoppackage/contents/views/Panel.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/e53fd6b066d569ae8247e5565c51560ace7af078
Comment 28 Nate Graham 2024-03-25 19:24:38 UTC
Git commit abad7a55865f8ad2e936b34b33ffa5c2fe7d5598 by Nate Graham, on behalf of Niccolò Venerandi.
Committed on 25/03/2024 at 19:10.
Pushed by ngraham into branch 'Plasma/6.0'.

Do not activate containment when one of its applet is activated

Reasoning is that some applets use "activated" when they would to trigger
their action, e.g. the show desktop applet. If the containment (here, the
panel) also gets activated as a result, it will get mouse input and a blue
line will appear. Previously this was avoided by some hacky code that (a)
apparently was not working for some people and (b) broke auto-hide and
dodge windows after clicking on "Minimize all".

This will also allow us to delete the hack in plasma-desktop.
Related: bug 483941
FIXED-IN: 6.0.3
(cherry picked from commit 6794ae6ab7c2c50f5ac57d7f32f5db1f7347201c)

M  +0    -1    src/plasma/containment.cpp

https://invent.kde.org/plasma/libplasma/-/commit/abad7a55865f8ad2e936b34b33ffa5c2fe7d5598
Comment 29 Fernando M. Muniz 2024-04-21 14:17:34 UTC
Sorry, but I found leftovers of this issue:

1) If you have some of folders vertically aligned, then delete one, and press the left/right arrow keys; You no longer can use the up/down arrow keys to select the other folders.

2) The same happens if you indeed have a folder on the left/right, but it's not vertically aligned with the folder you just deleted.
Comment 30 Fernando M. Muniz 2024-04-21 14:19:01 UTC
2) Horizontally aligned***
Comment 31 Nate Graham 2024-04-21 14:39:59 UTC
Those are different issue; please don't re-open existing bug reports for them.