Bug 478783 - Stop depending on QuickWebEngineDownloadRequest private header
Summary: Stop depending on QuickWebEngineDownloadRequest private header
Status: REPORTED
Alias: None
Product: angelfish
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Jonah Brüchert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-20 19:13 UTC by Soren Stoutner
Modified: 2023-12-22 21:46 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Soren Stoutner 2023-12-20 19:13:34 UTC
Angelfish currently depends on a private header for QuickWebEngineDownloadRequest.  This complicates efforts to maintain proper Qt WebEngine security support in Debian.  See the following two Debian bugs for context:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1059164
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1057755

Qt 6 has a public version of this API:

https://doc.qt.io/qt-6/qml-qtwebengine-webenginedownloadrequest.html

But for some reason, Anglefish uses the private header instead of the public one, even though I can't see anything Anglefish is doing that can't be done with the public API.

From https://invent.kde.org/network/angelfish/-/blob/master/lib/angelfishwebprofile.cpp?ref_type=heads

    #include <private/qquickwebenginedownloadrequest_p.h>

If Anglefish does somehow need some functionality that is not included in the public API, the best course of action would probably be to request that Qt publicly expose that functionality.
Comment 1 Soren Stoutner 2023-12-22 21:46:41 UTC
I submitted an upstream bug report requesting that Qt make the needed parts of the API public.

https://bugreports.qt.io/browse/QTBUG-120370