Bug 478745 - Crash, and clip incorrectly replaced. I uploaded a simple demo to reproduce
Summary: Crash, and clip incorrectly replaced. I uploaded a simple demo to reproduce
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: 23.08.4
Platform: Flatpak Linux
: HI crash
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-20 01:43 UTC by red_Arti
Modified: 2024-02-06 02:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
kdenlive-sequence-bug (1.75 MB, application/x-7z-compressed)
2023-12-20 01:43 UTC, red_Arti
Details

Note You need to log in before you can comment on or make changes to this bug.
Description red_Arti 2023-12-20 01:43:18 UTC
Created attachment 164299 [details]
kdenlive-sequence-bug

SUMMARY
I uploaded a simple demo project to reproduce.
Here it can reproduce 2 bugs:
Bug 1. Clip in sequence track incorrectly replaced by another clip, after the original clip deleted
BUg 2. Crash caused by sequence


STEPS TO REPRODUCE
This is what I did to create the bug demo project zip:
1. Create project
2. Add to project:   1.mp4, 2.mp4, 3.mp4  , p1.jpg, p2.jpg,   

3. Create 3 sequences
4. Add those pictures and videos to the 3 sequences' tracks:
     Sequence 1:    1.mp4,  3.mp4    , p1.jpg
     Sequence 2:    1.mp4,  2.mp4    , p2.jpg
     Sequence 3:    1.mp4,  3.mp4    , p1.jpg, p2.jpg

5. Add Sequence 1 into Sequence 2
6. Add Sequence 2 into Sequence 3. Now:
     Sequence 1:    1.mp4,  3.mp4                , p1.jpg
     Sequence 2:    1.mp4,  2.mp4   , Seq 1    , p2.jpg
     Sequence 3:    1.mp4,  3.mp4   , Seq 2      , p1.jpg, p2.jpg

7. Close Sequence 1 and Sequence 2 tabs. Leave Sequence 3 tab open.
8. Save the project and close Kdenlive

9. Edit p2.jpg with a drawing app to make it different
10. Move 2.mp4 and 3.mp4 to a sub folder to make them in different path

(Now I packed all the files into zip)

(Developer start from below to reproduce bug)
1. Open the project in Kdenlive 
2. Click "Use placeholders for missing clips" and "OK"
3. Delete 1.mp4, 2.mp4, 3.mp4 in project bin. Notice when you delete 2.mp4, no warning cause Sequence 2 is not open !!
4. Doubleclick Sequence 2 to open its tab. You see the place of 2.mp4 in track incorrectly replaced by a no-audio Seq 3 !!
5. Doubleclick Sequence 1 to open its tab. Crash !!

OBSERVED RESULT
Described above 

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Kdenlive 23.08.4 flatpak on Linux

ADDITIONAL INFORMATION
Comment 1 Jean-Baptiste Mardelle 2023-12-20 07:43:07 UTC
Thanks for the detailed report, will work on a fix asap
Comment 2 Bug Janitor Service 2023-12-22 16:51:15 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/kdenlive/-/merge_requests/454
Comment 3 Jean-Baptiste Mardelle 2023-12-23 13:39:24 UTC
Git commit 339869651fa12c721d789a5a8dbd7dc734c62964 by Jean-Baptiste Mardelle.
Committed on 23/12/2023 at 14:39.
Pushed by mardelle into branch 'master'.

Always keep all timeline models opened

This also might fix some issue with failing tests.

M  +31   -20   src/bin/abstractprojectitem.cpp
M  +9    -5    src/bin/abstractprojectitem.h
M  +18   -44   src/bin/bin.cpp
M  +0    -12   src/bin/bin.h
M  +160  -117  src/bin/projectclip.cpp
M  +3    -5    src/bin/projectclip.h
M  +2    -2    src/bin/projectitemmodel.cpp
M  +1    -1    src/bin/projectitemmodel.h
M  +28   -6    src/doc/kdenlivedoc.cpp
M  +2    -1    src/doc/kdenlivedoc.h
M  +42   -12   src/project/projectmanager.cpp
M  +1    -0    src/project/projectmanager.h
M  +4    -4    src/timeline2/model/clipmodel.cpp
M  +2    -2    src/timeline2/model/clipmodel.hpp
M  +2    -2    src/timeline2/model/timelineitemmodel.cpp
M  +10   -15   src/timeline2/model/timelinemodel.cpp
M  +1    -0    src/timeline2/model/timelinemodel.hpp
M  +2    -2    src/timeline2/view/timelinetabs.cpp
M  +5    -19   tests/filetest.cpp
M  +13   -14   tests/regressions.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/339869651fa12c721d789a5a8dbd7dc734c62964
Comment 4 Jean-Baptiste Mardelle 2024-01-16 20:46:22 UTC
Git commit e66afa13c9dd7a0e8f41946799e6249345772f85 by Jean-Baptiste Mardelle.
Committed on 16/01/2024 at 11:39.
Pushed by mardelle into branch 'release/23.08'.

Always keep all timeline models opened

This also might fix some issue with failing tests.

M  +31   -20   src/bin/abstractprojectitem.cpp
M  +9    -5    src/bin/abstractprojectitem.h
M  +18   -44   src/bin/bin.cpp
M  +0    -13   src/bin/bin.h
M  +160  -117  src/bin/projectclip.cpp
M  +3    -5    src/bin/projectclip.h
M  +2    -2    src/bin/projectitemmodel.cpp
M  +1    -1    src/bin/projectitemmodel.h
M  +28   -6    src/doc/kdenlivedoc.cpp
M  +2    -1    src/doc/kdenlivedoc.h
M  +42   -12   src/project/projectmanager.cpp
M  +1    -0    src/project/projectmanager.h
M  +20   -2    src/timeline2/model/clipmodel.cpp
M  +4    -1    src/timeline2/model/clipmodel.hpp
M  +10   -15   src/timeline2/model/timelinemodel.cpp
M  +1    -0    src/timeline2/model/timelinemodel.hpp
M  +1    -1    src/timeline2/view/timelinetabs.cpp
M  +5    -19   tests/filetest.cpp
M  +13   -14   tests/regressions.cpp

https://invent.kde.org/multimedia/kdenlive/-/commit/e66afa13c9dd7a0e8f41946799e6249345772f85
Comment 5 farid 2024-02-05 19:24:37 UTC
Does this work for you now?