Bug 478704 - Discover no longer offers the option to delete a Flatpak app's settings from ~/.var
Summary: Discover no longer offers the option to delete a Flatpak app's settings from ...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.27.10
Platform: Arch Linux Linux
: NOR major
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: regression
: 479991 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-12-19 01:59 UTC by Synthetic451
Modified: 2024-02-15 20:35 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27.10.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Synthetic451 2023-12-19 01:59:29 UTC
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***
Discover no longer offers the option to delete a Flatpak apps settings from ~/.var/app. It used to do this and was a very handy feature. As of a recent update, it no longer shows up.

STEPS TO REPRODUCE
1. Install a Flatpak app and launch it so that it creates a folder in ~/.var/app
2. Remove the Flatpak app
3. Notice that the Delete settings button no longer appears below the store thumbnails

OBSERVED RESULT
Delete settings button is gone.

EXPECTED RESULT
Delete settings button appears when an app has been uninstalled so that a user can clean up his ~/.var/app folder

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 6.6.7-arch1-1
(available in About System)
KDE Plasma Version: 5.27.10
KDE Frameworks Version: 5.113.0
Qt Version: 5.15.11

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2024-01-18 22:39:53 UTC
Can reproduce in Plasma 6 too.
Comment 2 ratijas 2024-01-25 15:48:30 UTC
This is a regression from fixing BUG 476148

ResourcesProxyModel::count property is a smart object now, but "thanks" to QML being so untyped and dynamic we missed the line in a completely different source file where it still tries to compare that smart object with a literal 0 and silently fails.
Comment 3 Bug Janitor Service 2024-01-25 15:55:09 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/746
Comment 4 ratijas 2024-01-25 16:05:53 UTC
Git commit 22296caf8ac667dd6508ca9eaff13310d2e97eef by ivan tkachenko.
Committed on 25/01/2024 at 16:54.
Pushed by ratijas into branch 'master'.

Flatpak: Fix up prompt to delete uninstalled app's data

This is a regression from porting count to a smart object for the sake
of better string interpolation.

Amends 576e460ade383da789727066929d14baa248aa02

M  +1    -1    libdiscover/backends/FlatpakBackend/qml/FlatpakRemoveData.qml

https://invent.kde.org/plasma/discover/-/commit/22296caf8ac667dd6508ca9eaff13310d2e97eef
Comment 5 ratijas 2024-01-25 16:08:12 UTC
Git commit 7b5c674dfd0625fdb9d5625a6630d4c5341f61da by ivan tkachenko.
Committed on 25/01/2024 at 17:07.
Pushed by ratijas into branch 'Plasma/6.0'.

Flatpak: Fix up prompt to delete uninstalled app's data

This is a regression from porting count to a smart object for the sake
of better string interpolation.

Amends 576e460ade383da789727066929d14baa248aa02
(cherry picked from commit 22296caf8ac667dd6508ca9eaff13310d2e97eef)

M  +1    -1    libdiscover/backends/FlatpakBackend/qml/FlatpakRemoveData.qml

https://invent.kde.org/plasma/discover/-/commit/7b5c674dfd0625fdb9d5625a6630d4c5341f61da
Comment 6 ratijas 2024-01-25 16:11:40 UTC
Git commit a84acbe8b5b87d1a6e9071ce61426d9622311f0c by ivan tkachenko.
Committed on 25/01/2024 at 17:10.
Pushed by ratijas into branch 'Plasma/5.27'.

Flatpak: Fix up prompt to delete uninstalled app's data

This is a regression from porting count to a smart object for the sake
of better string interpolation.

Amends 576e460ade383da789727066929d14baa248aa02
(cherry picked from commit 22296caf8ac667dd6508ca9eaff13310d2e97eef)

M  +1    -1    libdiscover/backends/FlatpakBackend/qml/FlatpakRemoveData.qml

https://invent.kde.org/plasma/discover/-/commit/a84acbe8b5b87d1a6e9071ce61426d9622311f0c
Comment 7 Nate Graham 2024-02-15 20:35:37 UTC
*** Bug 479991 has been marked as a duplicate of this bug. ***