Bug 478542 - Show Signatures Panel should open the sidebar if it is not already visible
Summary: Show Signatures Panel should open the sidebar if it is not already visible
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 23.08.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-15 10:15 UTC by Tristan Miller
Modified: 2023-12-23 04:18 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 24.02
Sentry Crash Report:


Attachments
A signed blank document showing the bug (20.27 KB, application/pdf)
2023-12-15 10:15 UTC, Tristan Miller
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tristan Miller 2023-12-15 10:15:58 UTC
Created attachment 164183 [details]
A signed blank document showing the bug

When opening a digitally signed document, Okular displays a "Show Signatures Panel" button between the toolbar and the top of the document.  If the sidebar happens to be visible already, then pressing this button shows the signatures panel.  But if the sidebar is not already visible, then pressing the button causes the sidebar button in the toolbar to activate, but the sidebar itself does not appear.


STEPS TO REPRODUCE
1. Make sure the sidebar is hidden.
2. Open any signed document, such as the attached PDF.
3. Press the "Show Signatures Panel" button.

OBSERVED RESULT
4. The "Show Sidebar" button in the toolbar activates, but the sidebar itself does not appear.

EXPECTED RESULT
4. The "Show Sidebar" button in the toolbar should activate and the sidebar itself should appear, with the signatures panel active.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.27.9
KDE Frameworks Version: 5.112.0
Qt Version: 5.15.11
Comment 1 Albert Astals Cid 2023-12-15 20:53:50 UTC
Sune this seems something you can probably convince your nice overlords to let you fix?
Comment 2 Bug Janitor Service 2023-12-18 18:58:07 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/okular/-/merge_requests/870
Comment 3 Albert Astals Cid 2023-12-18 19:06:45 UTC
Git commit 9b8284c54b0856681279afe596ac5e259ad7c6cc by Albert Astals Cid.
Committed on 18/12/2023 at 19:57.
Pushed by sune into branch 'master'.

Fix showing the side panel if not open when showing signatures panel

M  +3    -2    part/part.cpp

https://invent.kde.org/graphics/okular/-/commit/9b8284c54b0856681279afe596ac5e259ad7c6cc
Comment 4 Albert Astals Cid 2023-12-18 21:50:54 UTC
Git commit cac5da535917633895f697c4d01cd79fa017c2e2 by Albert Astals Cid.
Committed on 18/12/2023 at 22:31.
Pushed by aacid into branch 'release/23.08'.

Fix showing the side panel if not open when showing signatures panel
(cherry picked from commit 9b8284c54b0856681279afe596ac5e259ad7c6cc)

M  +3    -2    part/part.cpp

https://invent.kde.org/graphics/okular/-/commit/cac5da535917633895f697c4d01cd79fa017c2e2