Bug 478492 - Status OverlaySheet is too tall
Summary: Status OverlaySheet is too tall
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: qt6, regression
: 478565 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-12-14 00:25 UTC by guimarcalsilva
Modified: 2024-02-20 12:44 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
overlay sheet is too tall (126.53 KB, image/png)
2023-12-14 00:25 UTC, guimarcalsilva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description guimarcalsilva 2023-12-14 00:25:52 UTC
Created attachment 164152 [details]
overlay sheet is too tall

SUMMARY
If you update or install something and click on the percentage on the sidebar, the overlay sheet with the currently pending operations will show up. On Plasma 6 it's too tall. Check the attached screenshot for more info.

STEPS TO REPRODUCE
1. Open Discover
2. Start updating or installing something
3. Click on the progress bar to the left that says "Tasks"

OBSERVED RESULT
Overlay sheet with pending items is too tall

EXPECTED RESULT
Correct size.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.90.90
KDE Frameworks Version: 5.246.0
Qt Version: 6.0.0
Kernel Version: 6.2.0-37-generic (64-bit)
Processors: 6 × Intel® Core™ i5-9400F CPU @ 2.90GHz
Memory: 7,7 GiB of RAM
Graphics Processor: LLVM;
Comment 1 Nate Graham 2023-12-14 17:23:06 UTC
Can reproduce.
Comment 2 Nate Graham 2023-12-14 17:26:13 UTC
Setting an implicitHeight value on its ListView fixes the issue, so somehow its default implicit height isn't being set correctly.
Comment 3 ratijas 2023-12-14 18:18:59 UTC
OverlaySheet + ListView's implicit height will never be reliable. I did it for Dependencies sheet, and it quickly escalated into a bunch of horrible hacks. We should just use full pages IMHO
Comment 4 Nate Graham 2023-12-15 15:48:49 UTC
This tiny view doesn't make sense to be a page, though.
Comment 5 ratijas 2023-12-15 20:07:50 UTC
What if/when it's not tiny?
Comment 6 Nate Graham 2023-12-15 21:01:17 UTC
Then it needs a larger amount of vertical space. But that's rare compared to the common case of the popup having one or two things listed in it.

Regardless, this all worked properly with the OverlaySheet-based popup in Plasma 5 times, so there's some regression that needs fixing.
Comment 7 Nate Graham 2023-12-15 22:44:01 UTC
*** Bug 478565 has been marked as a duplicate of this bug. ***
Comment 8 Nicolas Fella 2024-02-20 12:44:58 UTC
Should be fixed with https://invent.kde.org/frameworks/kirigami/-/merge_requests/1454