The Digital Cameras page + the Device Actions page has a symbolic icon in the sidebar. It should be a colorful icon like every other entry. Both system-run and camera-photo have colorful variants. I couldn't figure out where it comes from, so I'm just filing a bug.
Are you sure this isn't simply due to the fact that the 22 icon is symbolic? The kcm certainly doesn't explicitly set the symbolic version https://invent.kde.org/plasma/plasma-desktop/-/blob/e050f5b6663a9e85d2c73cb2119127cff7ab41f4/solid-device-automounter/kcm/device_automounter_kcm.json#L35
(In reply to Harald Sitter from comment #1) > Are you sure this isn't simply due to the fact that the 22 icon is symbolic? > > The kcm certainly doesn't explicitly set the symbolic version > https://invent.kde.org/plasma/plasma-desktop/-/blob/ > e050f5b6663a9e85d2c73cb2119127cff7ab41f4/solid-device-automounter/kcm/ > device_automounter_kcm.json#L35 Probably that's the cause. Should they get a -symbolic version and 22px colorful version?
I have no idea how this is supposed to work to be honest :\ There are also preferences/ icons, maybe they should take preference but don't? All a bit mysterious. Specifically why are these icons symbolic when the category icon for Disks&Cameras is not? Probably needs some research or a more knowledgeable person.
Yes, this is caused by the fact that `drive-removable-media` is symbolic at the 22px size, which is the size shown in System Settings' sidebar. We already do have `drive-removable-media-symbolic` which is correctly symbolic at all sizes. So the issue really is that `drive-removable-media` isn't colorful at all sizes. This is fixable. Unfortunately we're not very far into the transition to the explicit "-symbolic" naming convention in client code , so I worry that if we do this, it will cause the icon which is currently correctly symbolic to turn colorful in all sorts of places. Let me do a search and see how many places in KDE code would need to be changed. Another possible fix is to make System Settings' sidebar list items taller and use the 32px icon size, which would force them all to be colorful if there are colorful versions. Yet another option is to say that 22px is a size that's really too small for colorful icons to make sense, and go in the other direction of appending `-symbolic` to the icons requested in the sidebar, making them all symbolic (assuming we have such icons).
kcm_solid_actions uses "system-run" which looks monochrome at 22px. kcm_kamera uses "camera-photo", which is also monochrome at 22px. (In reply to aronkvh from comment #2) > Probably that's the cause. Should they get a -symbolic version and 22px > colorful version? Basically yes. Alternatively, you could use new icons with different names, but either one would fix the issue. > Yes, this is caused by the fact that `drive-removable-media` is symbolic at the 22px size, which is the size shown in System Settings' sidebar. The problem isn't with drive-removable-media. That one looks colorful at 22px.
Just for the record, this is actually 2 separate bugs with 2 different KCMs, not a bug with kcm_deviceautomounter. kcm_kamera and kcm_solid-actions (actually kcm_solid_actions) would be the bugzilla component these bugs would be filed under.
Icon Explorer shows drive-removable-media being only symbolic at 22px size for me.
FWIW if we want to make `drive-removable-media` colorful at 22px, here are the places in KDE code where that icon is currently used, which would need to be audited to make sure a colorful icon would still make sense there. For any that don't, we would need to make the apps request `drive-removable-media-symbolic` instead. plasma-workspace/devicenotifications/devicenotifications.cpp 280: QStringLiteral("drive-removable-media-usb"), 300: QStringLiteral("drive-removable-media-usb"), plasma-workspace/applets/devicenotifier/package/contents/ui/main.qml 261: icon.name: "drive-removable-media" plasma-workspace/dataengines/hotplug/plasma-dataengine-hotplug.json 105: "Icon": "drive-removable-media-usb", kinfocenter/Modules/usbview/kcmusb.json 47: "Icon": "drive-removable-media-usb-pendrive", plasma-desktop/solid-device-automounter/kcm/device_automounter_kcm.json 35: "Icon": "drive-removable-media", kio/src/filewidgets/knewfilemenu.cpp 1374: d->m_menuDev = new KActionMenu(QIcon::fromTheme(QStringLiteral("drive-removable-media")), i18n("Link to Device"), this); kio/src/filewidgets/kfilecopytomenu.cpp 121: driveIcon = QStringLiteral("drive-removable-media"); amarok/src/core-impl/collections/umscollection/UmsCollection.cpp 394: return QIcon::fromTheme( "drive-removable-media-usb-pendrive" ); amarok/src/core-impl/collections/umscollection/podcasts/UmsPodcastProvider.cpp 171: return QIcon::fromTheme("drive-removable-media-usb-pendrive"); kpmcore/src/plugins/sfdisk/sfdiskbackend.cpp 276: icon = QStringLiteral("drive-removable-media-usb"); kio-extras/mtp/kio_mtp.cpp 52: entry.fastInsert(UDSEntry::UDS_ICON_NAME, QStringLiteral("drive-removable-media")); bluedevil/src/kio/obexftp/kioobexftp.cpp 512: entry.fastInsert(KIO::UDSEntry::UDS_ICON_NAME, QStringLiteral("drive-removable-media")); 521: entry.fastInsert(KIO::UDSEntry::UDS_ICON_NAME, QStringLiteral("drive-removable-media")); digikam/core/app/main/digikamapp_camera.cpp 78: d->usbMediaMenu->setIcon(QIcon::fromTheme(QLatin1String("drive-removable-media"))); digikam/core/dplugins/generic/webservices/filecopy/fcplugin.cpp 67: return QIcon::fromTheme(QLatin1String("drive-removable-media")); digikam/core/libs/database/collection/collectionmanager_location.cpp 290: *iconName = QLatin1String("drive-removable-media"); 372: *iconName = QLatin1String("drive-removable-media"); digikam/core/utilities/setup/collections/setupcollectionview.cpp 765: return QIcon::fromTheme(QLatin1String("drive-removable-media")); 885: return QIcon::fromTheme(QLatin1String("drive-removable-media-usb")).pixmap(16, QIcon::Disabled); solid/src/solid/devices/backends/iokit/iokitdevice.cpp 389: return QStringLiteral("drive-removable-media-usb"); 392: return QStringLiteral("drive-removable-media"); solid/src/solid/devices/backends/win/windevice.cpp 232: icon = QLatin1String("drive-removable-media-usb-pendrive"); solid/src/solid/devices/backends/udisks2/udisksdevice.cpp 623: return "drive-removable-media-usb"; 625: return "drive-removable-media"; 677: return "drive-removable-media-usb-pendrive"; kstars/kstars/ekos/manager.ui 456: <iconset theme="drive-removable-media">
(In reply to Nate Graham from comment #7) > Icon Explorer shows drive-removable-media being only symbolic at 22px size > for me. Strange, it works for me. Either way, the bug report is not actually about that icon: (In reply to aronkvh from comment #0) > The Digital Cameras page + the Device Actions page has a symbolic icon in > the sidebar. It should be a colorful icon like every other entry. Both > system-run and camera-photo have colorful variants. > I couldn't figure out where it comes from, so I'm just filing a bug.
FWIW, consensus from today's VDG discussion was to keep the icons colorful and 22px in size, so we have a path forward for fixing this.