Bug 478444 - Transform mask updates incorrectly when editing tweens sequentially
Summary: Transform mask updates incorrectly when editing tweens sequentially
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (show other bugs)
Version: 5.2.2
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-12 16:44 UTC by paleh
Modified: 2024-01-11 11:33 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description paleh 2023-12-12 16:44:16 UTC
SUMMARY
When editing one keyframe with the transform tool, then switching to edit another existing one, the keyframe data of the latter is replaced by the former, while the data of the former is replaced by the keyframe which precedes it.


STEPS TO REPRODUCE
1. Create a non-empty paint layer, add a transform mask to it and select the mask.
2. In the animation curves docker add a new frame at some t = A.
3. Add another frame at t = B, B  > A.
4. Using the transform tool, make a change at B, for example a translation. Press Enter.
5. Add another frame at t = C, C > B.
6. Using the transform tool, make a change at C. Press Enter.
7. Switch to A.
8. Select the transform tool. Click on the canvas.

OBSERVED RESULT
Keyframe data at A is replaced by the data at C. The data at C is replaced by the data at B.

EXPECTED RESULT
The data at A and C stays intact when the user initiates the transformation.

SOFTWARE/OS VERSIONS
Linux: Ubuntu 22.04
Qt Version: 5.15.7
Appimage

ADDITIONAL INFORMATION
Appeared in 5.2.0, regression compared to 5.1.5
In my opinion this is a severe bug because it makes tween animation borderline impossible (the best workaround I could find is to force the transform mask to apply to its current frame by making a change to the document (such as toggling the visibility of another layer) between editing each two existing frames
Comment 1 Dmitry Kazakov 2024-01-10 10:47:58 UTC
Hi, paleh!

Could you please check the nighly builds here when they are ready:

https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/2341/
https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Build/2249/

I have rewritten the animated transform masks in nightly version, so the bug might be fixed there.
Comment 2 paleh 2024-01-10 13:36:17 UTC
Hi, Dmitry!

Yes, the patch fixes the bug.
I also checked another animation curve bug(s) that I reported (bug 478448 / bug 478452), but this wasn't fixing it.
Comment 3 Dmitry Kazakov 2024-01-11 11:33:27 UTC
The bug is reportedly fixed