Bug 478252 - Impossible actions on video file that has just been played (renaming, moving)
Summary: Impossible actions on video file that has just been played (renaming, moving)
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Preview-Video (show other bugs)
Version: 8.3.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-12-08 10:16 UTC by nonobio
Modified: 2023-12-11 06:41 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 8.3.0
Sentry Crash Report:


Attachments
Can't rename video (2.50 MB, image/gif)
2023-12-10 10:00 UTC, nonobio
Details

Note You need to log in before you can comment on or make changes to this bug.
Description nonobio 2023-12-08 10:16:55 UTC
Hi,

Since Digikam 8.3.0, I cannot rename or move a video file that has just finished playing. I have to start playing another video to "release" the other video.

Thanks

***

STEPS TO REPRODUCE
1. Double-click on a video file to start preview playback
2. Wait for playback to finish and return to the list or thumbnail view
3. Try to rename or move the file that was just played

OBSERVED RESULT

The file cannot be renamed or moved, there are error messages indicating that this is not possible.

EXPECTED RESULT

Renaming or moving the file.

SOFTWARE/OS VERSIONS
Windows: 10
Qt Version: 6.6.0

ADDITIONAL INFORMATION

The good news is that video playback is now smooth, which was not the case with previous Digikam versions with which I always used an external player.
Comment 1 caulier.gilles 2023-12-08 10:33:39 UTC
Sound like the video file still locked on the computer by the internal video player (aka ffmpeg through Qt6Multimedia framework)
Comment 2 Maik Qualmann 2023-12-08 20:25:25 UTC
This is probably a Qt6 bug, we correctly set a NULL QUrl as source, this should close all file handlers according to the Qt doc. This is also correct under Linux, but not under Windows. Unfortunately, there are already bug reports in Qt for Qt5 that report this behavior and have not been fixed.

Maik
Comment 3 Maik Qualmann 2023-12-08 21:42:18 UTC
Git commit 1b0ccc238766f8c1266df83e7542477775cd334f by Maik Qualmann.
Committed on 08/12/2023 at 22:41.
Pushed by mqualmann into branch 'master'.

load a dummy video to release the latest loaded video

M  +1    -1    core/data/pics/digikam/CMakeLists.txt
A  +-    --    core/data/pics/digikam/video-digikam.mp4
M  +5    -10   core/libs/video/player/qtmm/mediaplayerview.cpp

https://invent.kde.org/graphics/digikam/-/commit/1b0ccc238766f8c1266df83e7542477775cd334f
Comment 4 nonobio 2023-12-10 07:32:16 UTC
Thanks, so do I have to download and install a nightly version? (digiKam-8.3.0-20231209T131146-Win64.exe)
Comment 5 Maik Qualmann 2023-12-10 07:40:26 UTC
Yes, exactly, the patch is included in this version.

Maik
Comment 6 nonobio 2023-12-10 07:53:25 UTC
Weird, I just installed it but I still have the same problem
Comment 7 Maik Qualmann 2023-12-10 09:21:29 UTC
I'll double check again later, but the problem no longer occurred for me.
You cannot move videos from the thumbnail bar if the video view is still open. It is clear that the video is still loaded because play should be possible at any time. We support deleting videos; here we close the video automatically.

Describe what exactly you do when the problem occurs.

Maik
Comment 8 nonobio 2023-12-10 10:00:38 UTC
Created attachment 164064 [details]
Can't rename video

I double-click on a video to display its preview in playback then I return to the thumbnail view (no need to wait for the end of the video), I then right-click to choose to rename the video (or F2), I enter the name, I validate: error.
If I play another video before doing all this, it works.
Comment 9 Maik Qualmann 2023-12-10 10:28:42 UTC
Ok, I can reproduce. I always use double click (single click in Linux) on the image/video view to exit it.
Using ESC or clicking on the toolbar, we will not close the video. I'll fix it.

Maik
Comment 10 Maik Qualmann 2023-12-10 15:04:45 UTC
Git commit 72264fca3c1bfdc10a1b476252b8377f87be6288 by Maik Qualmann.
Committed on 10/12/2023 at 16:03.
Pushed by mqualmann into branch 'master'.

fix stop of the media player when view change

M  +0    -3    core/app/views/stack/itemiconview.cpp
M  +9    -14   core/app/views/stack/stackedview.cpp
M  +0    -4    core/app/views/stack/stackedview.h
M  +0    -2    core/libs/video/player/qtmm/mediaplayerview.cpp
M  +10   -14   core/utilities/import/views/importstackedview.cpp
M  +0    -4    core/utilities/import/views/importstackedview.h
M  +0    -3    core/utilities/import/views/importview.cpp

https://invent.kde.org/graphics/digikam/-/commit/72264fca3c1bfdc10a1b476252b8377f87be6288
Comment 11 nonobio 2023-12-11 06:41:46 UTC
It is fixed with digiKam-8.3.0-20231210T221348-Win64.exe :)

Thanks a lot !