Bug 478169 - Selected items on the desktop sometimes inappropriately have black text
Summary: Selected items on the desktop sometimes inappropriately have black text
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Color scheme (show other bugs)
Version: 5.90.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: qt6, regression
Depends on:
Blocks:
 
Reported: 2023-12-06 14:53 UTC by Paragoumba
Modified: 2023-12-07 22:17 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot of the settings and the dark text (80.90 KB, image/png)
2023-12-06 14:53 UTC, Paragoumba
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paragoumba 2023-12-06 14:53:31 UTC
Created attachment 163944 [details]
screenshot of the settings and the dark text

SUMMARY


STEPS TO REPRODUCE
1. Use Breeze Dark
2. Change the color to white (#fff) in the settings
3. Select a file on the desktop

OBSERVED RESULT
The text is dark with a dark shadow, making it hard to read

EXPECTED RESULT
The text color should be different, maybe white on dark shadow

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: ArchLinux
KDE Plasma Version: 5.90.0
KDE Frameworks Version: 5.246.0
Qt Version: 6.6.1

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2023-12-07 21:21:50 UTC
I can occasionally reproduce this. I haven't been able to figure out the condition that triggers it. I'm pretty sure it's a regression from https://invent.kde.org/plasma/plasma-desktop/-/commit/af9238626f6aaf40fb8270dc4b46fbbb5371212e though.

FWIW the accent color isn't related here; the text color is hardcoded to white, because it has a shadow behind it that's hardcoded to black. Other colors don't really make sense in this context.
Comment 2 Nate Graham 2023-12-07 22:07:31 UTC
Ah, I think I got it.
Comment 3 Nate Graham 2023-12-07 22:17:35 UTC
Git commit 62c28925a0b06f75942665478eeae4df74e46753 by Nate Graham.
Committed on 07/12/2023 at 23:17.
Pushed by ngraham into branch 'master'.

Folder View: fix text color for desktop icons

The conditions were mis-designed so we checked for selection status
without also checking whether we were in list view, which is the only
place where it matters.

M  +8    -5    containments/desktop/package/contents/ui/FolderItemDelegate.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/62c28925a0b06f75942665478eeae4df74e46753