Bug 478164 - Directory merge is activated automatically on rescan
Summary: Directory merge is activated automatically on rescan
Status: CONFIRMED
Alias: None
Product: kdiff3
Classification: Applications
Component: application (show other bugs)
Version: 1.10.6
Platform: Compiled Sources All
: NOR wishlist
Target Milestone: ---
Assignee: michael
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-06 13:30 UTC by henktiggelaar
Modified: 2024-07-28 16:10 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description henktiggelaar 2023-12-06 13:30:33 UTC 
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Compare two (nearly) identical folders in KDiff3 without enabling merge
2. Choose Folder > Rescan (Shift+F5)
3. Double click any identical or changed file

OBSERVED RESULT
Merge operation is started on double click.

EXPECTED RESULT
Compare operation should be started on double click. My guess is that the problem is due to line 695 in directorymergewindow.cpp where init(true) should be init(bDirectoryMerge, true). 

SOFTWARE/OS VERSIONS
Windows: 10
KDE Frameworks Version: 5.110
Qt Version: 5.15.10

ADDITIONAL INFORMATION
Comment 1 michael 2024-05-19 19:35:39 UTC 
Seems like good idea for improvement. The current design seems to be intentional updating for the whole directory  rather than just the changed file.