Bug 478121 - Elisa mobile UI: playlist drawer cannot be closed anymore
Summary: Elisa mobile UI: playlist drawer cannot be closed anymore
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 23.08.3
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
: 478388 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-12-05 19:51 UTC by Kevin Kofler
Modified: 2023-12-24 02:04 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 23.08.5


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Kofler 2023-12-05 19:51:22 UTC
SUMMARY
In Elisa 23.08.3, in the mobile/touch UI, if the playlist drawer is open, there is no way to close it. Dragging it to the screen edge with the finger no longer works, it does not move even by a single pixel. Touching outside of the playlist also does nothing. Touching the "Show playlist" button again is not possible because it is covered by the drawer (and even if it were not, I guess it would not respond anyway). Hitting the X button on the bottom closes the entire application (which appears to be the only way to get rid of the playlist drawer).

STEPS TO REPRODUCE
1. Install Elisa on Plasma Mobile. (I use the Manjaro ARM elisa-qtmm package, but I doubt it depends on the multimedia backend.)
2. Open Elisa.
3. Touch (click) the "Show playlist" button.
4. Try to close the playlist drawer in various ways.

OBSERVED RESULT
The playlist drawer does not budge.

EXPECTED RESULT
The playlist drawer can be closed.

SOFTWARE/OS VERSIONS
Hardware: PINE64 PinePhone (original Allwinner A64 model, Beta Edition with Convergence Package (dock not plugged in))
Linux/KDE Plasma: Manjaro ARM (Plasma Mobile Edition, aarch64)
KDE Plasma Version: 5.27.9
KDE Frameworks Version: 5.112.0
Qt Version: 5.15.11
Elisa Version: elisa-qtmm 23.08.3-1

ADDITIONAL INFORMATION
This is a regression compared to at least 22.12.3. (Since intermediate versions were not packaged as elisa-qtmm, I cannot tell the exact version where the regression happened.)
Comment 1 Kevin Kofler 2023-12-05 23:40:18 UTC
I suspect that the regression is caused by this commit: https://invent.kde.org/multimedia/elisa/-/commit/6df31bbb78145633a187c56aa25389fee7e45a10
Comment 2 Kevin Kofler 2023-12-05 23:58:37 UTC
This should probably say:
interactive: Kirigami.Settings.isMobile
instead of:
interactive: false
Comment 3 Nate Graham 2023-12-07 23:29:40 UTC
Good catch. Would you like to submit a merge request?
Comment 4 Bug Janitor Service 2023-12-08 23:33:05 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/528
Comment 5 Kevin Kofler 2023-12-10 05:40:55 UTC
Git commit 2d73416c9382b5b6a3535612719ff2c94dc0246a by Kevin Kofler.
Committed on 10/12/2023 at 06:36.
Pushed by kkofler into branch 'release/23.08'.

Make context drawer interactive on mobile (#478121)

src/qml/ElisaMainWindow.qml (contextDrawer): Change interactive: false
to interactive: Kirigami.Settings.isMobile. Otherwise, it is impossible
to close the context (playlist) drawer (with touch only) on mobile
platforms such as the PinePhone. Update the comment accordingly.

M  +4    -3    src/qml/ElisaMainWindow.qml

https://invent.kde.org/multimedia/elisa/-/commit/2d73416c9382b5b6a3535612719ff2c94dc0246a
Comment 6 Kevin Kofler 2023-12-10 21:19:41 UTC
Git commit b8df28c83f3561e213a006b3c76971749506be72 by Kevin Kofler.
Committed on 10/12/2023 at 06:45.
Pushed by kkofler into branch 'master'.

Make context drawer interactive on mobile (#478121)

src/qml/ElisaMainWindow.qml (contextDrawer): Change interactive: false
to interactive: Kirigami.Settings.isMobile. Otherwise, it is impossible
to close the context (playlist) drawer (with touch only) on mobile
platforms such as the PinePhone. Update the comment accordingly.

M  +4    -3    src/qml/ElisaMainWindow.qml

https://invent.kde.org/multimedia/elisa/-/commit/b8df28c83f3561e213a006b3c76971749506be72
Comment 7 Jack Hill 2023-12-12 13:20:17 UTC
*** Bug 478388 has been marked as a duplicate of this bug. ***
Comment 8 Kevin Kofler 2023-12-24 02:04:12 UTC
An update on when this fix will ship: This is already fixed in the development release 24.01.85 (24.02 Beta 2). The stable release 23.08.5, which will also include this fix (as it has already been pushed to the 23.08 release branch) is now scheduled for Thursday, February 15, 2024. The next feature release, 24.02.0, currently scheduled for Wednesday, February 28, 2024, will also include this fix.

Distributions may of course backport the fix earlier. The Manjaro ARM elisa-qtmm package is already patched.