Bug 478022 - When clicking log out, restart, or power off, confirmation screen has all options, not just the one I chose earlier
Summary: When clicking log out, restart, or power off, confirmation screen has all opt...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: 5.27.9
Platform: Fedora RPMs Linux
: NOR minor
Target Milestone: 1.0
Assignee: Nate Graham
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2023-12-04 03:58 UTC by Neal Gompa
Modified: 2024-01-29 17:18 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.1


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Neal Gompa 2023-12-04 03:58:55 UTC
SUMMARY
When I'm trying to log out; restart; or power off the computer, Plasma pops up a prompt re-asking me if I want to do any of those three actions, rather than just confirming the action I already selected.


STEPS TO REPRODUCE
1. Select Log out/Restart/Power off from the panel

OBSERVED RESULT
Plasma pops up a prompt re-asking me if I want to do any of those three actions.

EXPECTED RESULT
Plasma pops up a prompt confirming I want to do the action I already invoked.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: Fedora Linux 39 (KDE Plasma)
(available in About System)
KDE Plasma Version: 5.27.9
KDE Frameworks Version: 5.111.0
Qt Version: 5.15.11
Comment 1 David Edmundson 2023-12-11 14:59:28 UTC
Just to confirm, is this about the UX being a bit weird or is it completely broken. Does it have the text "[performing action] in 30 seconds" ?
Comment 2 Nate Graham 2023-12-11 15:02:49 UTC
My understanding was that it's the UX being weird, but Neal should confirm.
Comment 3 Neal Gompa 2023-12-11 18:09:36 UTC
It is the UX being weird. It causes me to accidentally do a different action sometimes too.
Comment 4 Bug Janitor Service 2024-01-25 05:09:04 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3823
Comment 5 Nate Graham 2024-01-29 17:18:57 UTC
Git commit aeafc00970259e5f1594f284e2bef30a50975688 by Nate Graham.
Committed on 29/01/2024 at 16:56.
Pushed by ngraham into branch 'master'.

Simplify logout greeter UI when invoked with a specific option

Right now the logout greeter always shows all available power/session
actions (except for Lock, for some reason) regardless of how it was
invoked, plus a cancel button and an OK button.

As a result, though it is essentially a confirmation screen, it offers the
user options to change their mind after the fact and perform a different
action from the one they started with, including those like Sleep and
Hibernate that don't exit the session at all.

This isn't ideal as it presents a somewhat strange and cluttered UI to
the user, full of options that are unlikely to be used.

To improve the situation, when the dialog is invoked with a specific
option, now we only show that option plus a cancel button.

When the dialog is *not* invoked with any option, (e.g. from the
off-by-default "Leave" item in the desktop context menu, or the
Ctrl+Alt+Delete global shortcut), all options are still shown, with
"Shut Down" pre-selected--as was the prior intention, but it wasn't
working. This required some re-plumbing as the dialog wasn't previously
designed to support this kind of dual-mode operation. The greeter's
windowed test mode is also updated to always show all available options.
FIXED-IN: 6.1

M  +7    -7    containmentactions/contextmenu/menu.cpp
M  +1    -0    ksmserver/org.kde.LogoutPrompt.xml
M  +14   -0    libkworkspace/sessionmanagement.cpp
M  +6    -0    libkworkspace/sessionmanagement.h
M  +10   -1    logout-greeter/greeter.cpp
M  +1    -0    logout-greeter/greeter.h
M  +73   -81   lookandfeel/org.kde.breeze/contents/logout/Logout.qml
M  +12   -2    startkde/session-shortcuts/main.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/aeafc00970259e5f1594f284e2bef30a50975688