Bug 477995 - Breeze lock screen theme mis-renders icons from many 3rd-party icon themes
Summary: Breeze lock screen theme mis-renders icons from many 3rd-party icon themes
Status: VERIFIED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Theme - Breeze (show other bugs)
Version: 5.90.0
Platform: Neon Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: qt6
: 481657 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-12-03 15:16 UTC by Nico
Modified: 2024-02-22 18:05 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0
Sentry Crash Report:


Attachments
Lockscreen with missing icons (133.12 KB, image/png)
2023-12-03 15:16 UTC, Nico
Details
Confirm logout screen with missing icons (359.34 KB, image/png)
2023-12-03 15:20 UTC, Nico
Details
Shutdown dialog using Adwaita (287.12 KB, image/png)
2023-12-05 18:00 UTC, Nico
Details
System settings using Adwaita (647.84 KB, image/png)
2023-12-05 18:02 UTC, Nico
Details
Cuttlefish searching for system-log-out iin the front on my host using Papirus, Adwaita in my Neon VM the back (324.45 KB, image/png)
2023-12-05 19:45 UTC, Nico
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nico 2023-12-03 15:16:45 UTC
Created attachment 163816 [details]
Lockscreen with missing icons

SUMMARY
Lockscreen icons are missing when using the Papirus icon theme

STEPS TO REPRODUCE
1. Set Paprius as icon theme
2. Lock screen

OBSERVED RESULT
Sleep and switch user icons are missing

EXPECTED RESULT
Show an icon, if the icon theme does not include one fallback to Breeze

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.90.0
KDE Frameworks Version: 5.246.0
Qt Version: 6.6.0
Kernel Version: 6.2.0-37-generic (64-bit)
Graphics Platform: Wayland

ADDITIONAL INFORMATION
Comment 1 Nico 2023-12-03 15:20:24 UTC
The same also happens to the confirm logout screen, not sure if it is related.
Comment 2 Nico 2023-12-03 15:20:42 UTC
Created attachment 163818 [details]
Confirm logout screen with missing icons
Comment 3 Nate Graham 2023-12-05 17:48:26 UTC
KDE doesn't have any control over 3rd-party icon themes. If a theme is missing icons and doesn't set its fallback to Breeze, there's nothing we can do about it.

That said, your screenshot doesn't show that the icons are missing; they're incorrect. This means that the problem is *triply* in the Papirus icon theme. :)
Comment 4 Nico 2023-12-05 17:50:10 UTC
I thought about that but the theme contains
```
[Icon Theme]
Name=Papirus-Dark
Comment=Papirus icon theme for dark themes
Inherits=breeze-dark,hicolor
```

So I would except that it correctly falls back to Breeze here.
Comment 5 Nico 2023-12-05 18:00:54 UTC
Created attachment 163912 [details]
Shutdown dialog using Adwaita

Installed adwaita using `apt install adwaita-icon-theme-full` and it has a similar issue.
So you're saying even Adwaita is problematic here?
Comment 6 Nico 2023-12-05 18:02:50 UTC
Created attachment 163913 [details]
System settings using Adwaita

Same for system settings. I still think Plasma should have a fallback here
Comment 7 Nate Graham 2023-12-05 19:08:43 UTC
The fact that it has a fallback to breeze-dark doesn't matter if the theme itself actually has a matching icon. Then there's no fallback effect. Like I said, it seems like the Papirus icons here are just broken.
Comment 8 Nate Graham 2023-12-05 19:14:08 UTC
Oh hmm, maybe I'm wrong, as I see the icons are empty (rather than broken) and not falling back to breeze-dark.

Can you check Papirus and Adwaita to see if they contain the "system-log-out" icon? And if not, can you find out what name they use for this icon?
Comment 9 Nico 2023-12-05 19:45:42 UTC
Created attachment 163917 [details]
Cuttlefish searching for system-log-out iin the front on my host using Papirus, Adwaita in my Neon VM the back

Seems like Adwaita uses `system-log-out-symbolic` and Papirus doesn't have it
Comment 10 david 2023-12-27 13:08:47 UTC
The issue is with the symbolic icons. With Papirus logout icons, they are all circles with different colors, but when symbolic, the only thing that can be seen is the shape. I would like to have colorful icons, it greatly improves visibility. And normal icons are so much better as they can follow the current color scheme. Customization is one of Plasma's best features, so please don't take it away from us. It would be nice having a tickbox like "Use symbolic icons" (somewhere related to Plasma style). Take a look at Materia-kde theme. It has a colorful and symbolic variant. They both use Papirus icons. Right now, you can't replicate those themes in Plasma 6.
Comment 11 Nate Graham 2024-01-17 23:16:39 UTC
We made a change to how symbolic icons are loaded. Can you try again with today's git master?
Comment 12 Nico 2024-01-18 11:12:42 UTC
I only have a VM with KDE Neon Unstable Edition. I've updated it to the latest version, but I couldn't see any difference as of now. Not sure if the change is already included
Comment 13 Nate Graham 2024-01-18 21:46:38 UTC
Ok, thanks.
Comment 14 david 2024-02-13 01:32:46 UTC
Still looks the same, latest neon unstable live iso. I'm also having to logout for panel's icons to change.
Comment 15 Nate Graham 2024-02-13 21:02:17 UTC
Can reproduce with Oxygen, ePapirus, and Crystal Remix icon themes as well.
Comment 16 Nate Graham 2024-02-13 21:06:32 UTC
Found the issue; preparing a merge request.
Comment 17 Bug Janitor Service 2024-02-13 21:17:00 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3899
Comment 18 Nate Graham 2024-02-14 15:32:27 UTC
Git commit 8fa333fbac71c6e6068173198f8ccd92d2ba6df9 by Nate Graham.
Committed on 14/02/2024 at 15:03.
Pushed by ngraham into branch 'master'.

Revert "lookandfeel: Explicitely set isMask of ActionButton"

This reverts commit 2d46de674ced4062c53799772339ad152ffcbc69.

This change made sense to fix bug 474377 back when these icons came from
the Plasma style. However subsequently that feature was removed. As a
result, icons from the desktop icon theme are now shown here, and we
can't guarantee their visual style. As such, forcing them to be a mask
is now incorrect and obliterates the icon if it's using the full-color
style.
Related: bug 474377
FIXED-IN: 6.0

M  +0    -1    lookandfeel/components/ActionButton.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/8fa333fbac71c6e6068173198f8ccd92d2ba6df9
Comment 19 Nate Graham 2024-02-14 16:37:31 UTC
Git commit e442160ea44c4aff05b53228e045a43f16907201 by Nate Graham.
Committed on 14/02/2024 at 15:38.
Pushed by ngraham into branch 'Plasma/6.0'.

Revert "lookandfeel: Explicitely set isMask of ActionButton"

This reverts commit 2d46de674ced4062c53799772339ad152ffcbc69.

This change made sense to fix bug 474377 back when these icons came from
the Plasma style. However subsequently that feature was removed. As a
result, icons from the desktop icon theme are now shown here, and we
can't guarantee their visual style. As such, forcing them to be a mask
is now incorrect and obliterates the icon if it's using the full-color
style.
Related: bug 474377
FIXED-IN: 6.0


(cherry picked from commit 8fa333fbac71c6e6068173198f8ccd92d2ba6df9)

M  +0    -1    lookandfeel/components/ActionButton.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/e442160ea44c4aff05b53228e045a43f16907201
Comment 20 Nate Graham 2024-02-22 17:17:34 UTC
*** Bug 481657 has been marked as a duplicate of this bug. ***
Comment 21 Nico 2024-02-22 18:02:42 UTC
I can confirm the issue being fixed in my Neon VM now. Although it looks a bit off with the update and restart icon, but I guess Papirus needs to add an icon for this.
Comment 22 Nate Graham 2024-02-22 18:05:19 UTC
Great, thanks for testing again!