Bug 477975 - do not link KF::DocTools, it is not used in the code
Summary: do not link KF::DocTools, it is not used in the code
Status: RESOLVED FIXED
Alias: None
Product: Haruna
Classification: Applications
Component: generic (other bugs)
Version First Reported In: unspecified
Platform: Arch Linux Linux
: NOR task
Target Milestone: ---
Assignee: george fb
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-12-03 09:04 UTC by Nick Korotysh
Modified: 2023-12-10 11:57 UTC (History)
0 users

See Also:
Latest Commit: https://invent.kde.org/multimedia/haruna/-/commit/6e19c9e65f99ea02088e71dbc98045eeca600c07
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
chnages to build with Qt6 and no KDocTools (1.08 KB, patch)
2023-12-03 09:04 UTC, Nick Korotysh 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Korotysh 2023-12-03 09:04:56 UTC 
Created attachment 163805 [details]
chnages to build with Qt6 and no KDocTools

SUMMARY
***
KF6::DocTools is listed in target_link_libraries() in src/CMakeLists.txt, but it is not required - it is not used in code, only some tools from kdoctools package are used for documentation generation.
***


STEPS TO REPRODUCE
1. remove kdoctools package
2. run cmake, everything is ok
3. build

OBSERVED RESULT
build failed, KDocTools is required to link the application

EXPECTED RESULT
successful build, as KDocTools is optional package (according to root CMakeLists.txt)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: ArchLinux/KDE Plasma 6 Beta, Wayland
KDE Plasma Version: 5.90.0
KDE Frameworks Version: 5.246.0
Qt Version: 6.6.1

ADDITIONAL INFORMATION
doc/CMakeLists.txt also needs to be updated - it checks only for KF5DocTools
Comment 1 george fb 2023-12-10 11:57:39 UTC 
Git commit 6e19c9e65f99ea02088e71dbc98045eeca600c07 by George Florea Bănuș.
Committed on 10/12/2023 at 12:56.
Pushed by georgefb into branch 'master'.

cmake: don't link to KF6::DocTools

M  +1    -1    doc/CMakeLists.txt
M  +0    -1    src/CMakeLists.txt

https://invent.kde.org/multimedia/haruna/-/commit/6e19c9e65f99ea02088e71dbc98045eeca600c07