Bug 477811 - The panel context menu says "Exit Edit Mode" but it actually doesn't exit edit mode, and instead toggles the visibility for the edit mode toolbox
Summary: The panel context menu says "Exit Edit Mode" but it actually doesn't exit edi...
Status: RESOLVED DUPLICATE of bug 476970
Alias: None
Product: plasmashell
Classification: Plasma
Component: Panel (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-12-01 01:50 UTC by guimarcalsilva
Modified: 2023-12-01 15:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description guimarcalsilva 2023-12-01 01:50:45 UTC
SUMMARY
The panel context menu says "Exit Edit Mode" while in editing mode even when the edit mode toolbox is not visible. The context menu option actually works as a toggle for the toolbox: if the edit mode toolbox is visible and you click on the option, it dismisses it, but if it's not visible and you click on "Exit Edit Mode" it brings it up. Either way, the label doesn't describe what the entry actually does. For that reason, maybe it should be named "Toggle Edit Mode Toolbox" if that's the original intent, or, if it's actually meant to fully exit Edit Mode, then it should do that. Maybe we need two entries, one for toggling the edit mode toolbox and another for fully exiting the edit mode?

STEPS TO REPRODUCE
1. Open Edit Mode
2. Press ESC to hide the edit mode toolbox
3. Right-click on taskbar
4. Click on "Exit Edit Mode"

OBSERVED RESULT
The context-menu option works as a toggle for the edit mode toolbox instead of exiting the edit mode, as the name implies.

EXPECTED RESULT
Either make it exit the edit mode as the text says or change the button to say "Toggle Edit Mode Toolbox" if that's the intention. Another possibility is to have two entries, one for fully exiting edit mode and another for toggling the toolbox visibility.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.90.0
KDE Frameworks Version: 5.246.0
Qt Version: 6.6.0
Comment 1 Bug Janitor Service 2023-12-01 12:32:51 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3637
Comment 2 Nate Graham 2023-12-01 15:40:11 UTC
*** This bug has been marked as a duplicate of bug 476970 ***