Bug 477792 - The playlist in party mode in Elisa is broken
Summary: The playlist in party mode in Elisa is broken
Status: RESOLVED FIXED
Alias: None
Product: frameworks-qqc2-desktop-style
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: 5.246.0
Platform: Neon Linux
: VHI normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-11-30 19:16 UTC by maan
Modified: 2023-12-08 14:22 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
screenshot light theme (198.90 KB, image/png)
2023-11-30 19:20 UTC, maan
Details
2.png - screenshot dark theme (235.83 KB, image/png)
2023-11-30 19:21 UTC, maan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description maan 2023-11-30 19:16:05 UTC
SUMMARY

On KDE neon Unstable Edition 22.04 (x86_64) - all updates applied as of 30.11.2023 20:00 CET and Elisa 24.01.80, the playlist is not visible when in party mode, using the light theme (attachment 1 [details].png). When in dark mode the list is visible, but the background is still a solid color (attachment 2 [details].png).

STEPS TO REPRODUCE
1.  Open Elisa and play a song
2.  Switch to the Party Mode3. 

OBSERVED RESULT

The playlist has a solid color background and is not possible to read the song titles in light mode.

EXPECTED RESULT

Song titles are readable in both light and dark modes. Background of the playlist blends with the rest of the background, instead of being a solid color. 

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: KDE neon Unstable Edition 22.04 (x86_64)
KDE Plasma Version: 5.90.0
KDE Frameworks Version: 5.246.0
Qt Version: 6.6.0

ADDITIONAL INFORMATION
Comment 1 maan 2023-11-30 19:20:19 UTC
Created attachment 163666 [details]
screenshot light theme
Comment 2 maan 2023-11-30 19:21:25 UTC
Created attachment 163667 [details]
2.png - screenshot dark theme
Comment 3 Jack Hill 2023-12-05 15:06:36 UTC
Thanks for reporting this. It looks like you uploaded the wrong attachments though. Also, did you mean to post this in the upnp component or the general component?
Comment 4 maan 2023-12-05 18:23:06 UTC
(In reply to Jack Hill from comment #3)
> Thanks for reporting this. It looks like you uploaded the wrong attachments
> though. Also, did you mean to post this in the upnp component or the general
> component?

The attachments in the summary are broken, I do not know why. But i have added the 2 attachments as comments 1 and 2 below. I do not know where should I have posted this. Should I move it under the general component?
Comment 5 Jack Hill 2023-12-05 22:47:55 UTC
Ah, I didn't realise those two attachments were different. I can confirm this now. The UPnP component is for universal plug and play, which I believe is broken in Elisa. I've moved it to general now.
Comment 6 Nate Graham 2023-12-07 22:25:20 UTC
Eek, can confirm.
Comment 7 Nate Graham 2023-12-07 23:24:21 UTC
Looks like this is a regression from porting to be base on ItemDelegate. The base unhovered background color isn't transparent like it probably should be.
Comment 8 Bug Janitor Service 2023-12-07 23:26:26 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/338
Comment 9 Nate Graham 2023-12-08 14:22:37 UTC
Git commit b0167e224fa1eaa6c1c94322102b8fd61073f39a by Nate Graham.
Committed on 08/12/2023 at 00:21.
Pushed by ngraham into branch 'master'.

Don't set a background color for normal unhovered list items

Currently the background styling we apply to ItemDelegate and others
uses the Kirigami theme's standard view background color for the
backgrounds of unhovered list items not using the alternate background
color. But this is unnecessary; when the list item is in a view that
itself uses the view background color, then the list item's own
background color simply matches that of the view it lives in. And when
the view intentionally does not use that background color, the result is
visual brokenness.

We can fix this by simply not setting a background color for the normal
unhovered state of the background.

M  +1    -1    org.kde.desktop/private/DefaultListItemBackground.qml

https://invent.kde.org/frameworks/qqc2-desktop-style/-/commit/b0167e224fa1eaa6c1c94322102b8fd61073f39a