I'd like to submit a feature request. Sieve Editor and the Sieve editor of Roundcube Webmail (managesieve) use different ways of naming a sieve filter. managesieve uses 'rule:[<name>]' sieveeditor uses 'SCRIPTNAME: <name>' Actually sieveditor leaves 'rule:[<name>]' alone, but managesieve removes 'SCRIPTNAME:<name>'. Maybe sieveeditor can add a flag to use 'rule:[<name>]' as well?
Hi, Ok I will look at it soon. Regards
See also: https://github.com/roundcube/roundcubemail/issues/9231
In your example #SCRIPTNAME: Deel 5 van script # rule:[invest filter] if anyof (header :contains "subject" "Invest in Films" , header :contains "subject" "Invest in Lithium Mining in Australia" , header :contains "subject" "Invest in" ) { setflag [ "\\Seen" ]; fileinto "Spam"; } sieveeditor keeps comments no ? What do you want that I fix ?
Created attachment 163641 [details] attachment-678072-0.html Actually, You are doing nothing wrong. It's more of a 'synchronization' thing between different sieve editors. I sometimes need tot use the Web Sieve Editor, and this removes all 'SCRIPTNAME' comments of your sieve editor. I thought, maybe as kind of a work-around you could support both ways of script naming conventions. Or detect the managesieve 'rule' naming convention and reuse it. Op 30-11-2023 om 10:40 schreef Laurent Montel: > https://bugs.kde.org/show_bug.cgi?id=477755 > > --- Comment #3 from Laurent Montel<montel@kde.org> --- > In your example > #SCRIPTNAME: Deel 5 van script > # rule:[invest filter] > if anyof (header :contains "subject" "Invest in Films" > , header :contains "subject" "Invest in Lithium Mining in Australia" > , header :contains "subject" "Invest in" > ) > { > setflag [ "\\Seen" ]; > fileinto "Spam"; > } > > sieveeditor keeps comments no ? > > What do you want that I fix ? >
Git commit 8e290a0377d8b4c19a57d52ed1d3b65453c138a2 by Laurent Montel. Committed on 30/11/2023 at 13:28. Pushed by mlaurent into branch 'master'. Fix BUG: 477755 rule:[<name>] as opposed to 'SCRIPTNAME: <name>' In Roundcube it uses "rule:" now we use same. FIXED-IN: 24.02.0 M +1 -1 src/ksieveui/autocreatescripts/autotests/data/add-flags-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/add-header-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/add-single-flag-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/address-with-default-all-parameter-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/address-with-default-is-parameter-ref.siv M +0 -1 src/ksieveui/autocreatescripts/autotests/data/body-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/body-without-bodytype-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/break-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/comparator-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/convert-action-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/delete-headers-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/enclose-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/extract-text-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/failed-2-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/fileinfo-ref.siv M +2 -2 src/ksieveui/autocreatescripts/autotests/data/full-example1-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/hasflag-ref.siv M +2 -2 src/ksieveui/autocreatescripts/autotests/data/include-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/keep-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/mailboxexist-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/not-condition-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/not-condition2-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/notify-2-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/notify-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/problem-with-inferior-char-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/redirect-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/reject-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/remove-flags-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/replace-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/setflag-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/simple-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-address-order-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-anti-slash-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-comment-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-comment3-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-comment4-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-comment5-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-comment6-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-comment8-ref.siv M +2 -2 src/ksieveui/autocreatescripts/autotests/data/test-comment9-ref.siv M +3 -3 src/ksieveui/autocreatescripts/autotests/data/test-current-date-custom-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-date-ref.siv M +2 -2 src/ksieveui/autocreatescripts/autotests/data/test-elseif-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-envelop-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-envelop-subadress-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-envelop-without-part-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-environnement-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-exists-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-foreach-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-foreverypart-complex-ref.siv M +2 -2 src/ksieveui/autocreatescripts/autotests/data/test-forwarding-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-has-flags-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-header-multilist-comment-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-header-multilist-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-header-value-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-headers-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-metadataexists-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-regexp-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-servermetadataexists-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-spam-plus-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-spam-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-text-with-backslash-ref.siv M +2 -2 src/ksieveui/autocreatescripts/autotests/data/test-vacation-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-value-as-list-quoted-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/test-virus-ref.siv M +1 -2 src/ksieveui/autocreatescripts/autotests/data/vacation-active-discard-ref.siv M +3 -4 src/ksieveui/autocreatescripts/autotests/data/vacation-multiple-ref.siv M +3 -4 src/ksieveui/autocreatescripts/autotests/data/vacation-multiple-with-undefined-command-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/vacation-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/variable-lower-ref.siv M +1 -1 src/ksieveui/autocreatescripts/autotests/data/variable-ref.siv M +12 -1 src/ksieveui/autocreatescripts/sievescriptlistbox.cpp https://invent.kde.org/pim/libksieve/-/commit/8e290a0377d8b4c19a57d52ed1d3b65453c138a2
Hi, now we use # rule:[...] as in roundcube => it will not have pb now. Thanks Regards
Great! Thank you. Hope it will find it's way to debian 12 soon...