Bug 477647 - Fill Tool Doesn't Grow When on All Layers Mode
Summary: Fill Tool Doesn't Grow When on All Layers Mode
Status: RESOLVED INTENTIONAL
Alias: None
Product: krita
Classification: Applications
Component: Tools/Colorize (other bugs)
Version First Reported In: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-28 00:59 UTC by Jeshuá
Modified: 2023-12-04 21:36 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
All Layer Mode 40px growth.png (76.91 KB, image/png)
2023-11-28 15:46 UTC, Jeshuá
Details
Same Layer Fill Mode.png (145.50 KB, image/png)
2023-11-28 15:46 UTC, Jeshuá
Details
All Layer Mode.png (57.12 KB, image/png)
2023-11-28 15:46 UTC, Jeshuá
Details
On a New File.png (71.57 KB, image/png)
2023-11-28 15:46 UTC, Jeshuá
Details
attachment-1298129-0.html (1.91 KB, text/html)
2023-12-04 21:36 UTC, Jeshuá
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeshuá 2023-11-28 00:59:39 UTC
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. I set my fill tool to grow 3 px to keep it clean, it's working on "current layer mode", but when on Fill the Merging of All Layers, it doesn't


OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 10
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Krita

 Version: 5.3.0-prealpha (git 042b578)
 Installation type: installer / portable package
 Hidpi: true

Qt

  Version (compiled): 5.15.7
  Version (loaded): 5.15.7
Comment 1 Jeshuá 2023-11-28 01:10:45 UTC
It fills normally when the boundary is black, the color before was almost white.
Comment 2 Deif Lou 2023-11-28 07:34:23 UTC
Please provide more information, a sample file with the drawing that you cannot fill correctly and a screenshot with all the tool settings you are using.
Comment 3 Jeshuá 2023-11-28 15:46:28 UTC
Created attachment 163575 [details]
All Layer Mode 40px growth.png

I actually can't share the file, sorry, but I'm sending one screenshot of
it also happening on a new file, I hope it helps!

Em ter., 28 de nov. de 2023 às 04:34, Deif Lou <bugzilla_noreply@kde.org>
escreveu:

> https://bugs.kde.org/show_bug.cgi?id=477647
>
> Deif Lou <ginoba@gmail.com> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>                  CC|                            |ginoba@gmail.com
>              Status|REPORTED                    |NEEDSINFO
>          Resolution|---                         |WAITINGFORINFO
>
> --- Comment #2 from Deif Lou <ginoba@gmail.com> ---
> Please provide more information, a sample file with the drawing that you
> cannot
> fill correctly and a screenshot with all the tool settings you are using.
>
> --
> You are receiving this mail because:
> You reported the bug.
Comment 4 Jeshuá 2023-11-28 15:46:29 UTC
Created attachment 163576 [details]
Same Layer Fill Mode.png
Comment 5 Jeshuá 2023-11-28 15:46:29 UTC
Created attachment 163577 [details]
All Layer Mode.png
Comment 6 Jeshuá 2023-11-28 15:46:29 UTC
Created attachment 163578 [details]
On a New File.png
Comment 7 Deif Lou 2023-11-28 21:22:46 UTC
It took me a while to decipher the situation, but I think I got it.
The reason is that you have the  "Stop growing at the darkest and/or more opaque pixels" option on. When dealing with colored lines this option assumes that the the lines are darker than the inside area (hence the "stop at darkest pixels" part). So in the case of using the merged layers as reference, you have gray inside and white line, so the growing stops when reaching the line, since the pixels start to be lighter. In the case of lighter lines you have to use the other method with transparent, otherwise it does not grow. This is expected.
Comment 8 Jeshuá 2023-12-04 21:36:29 UTC
Created attachment 163876 [details]
attachment-1298129-0.html

Oh, thank you haha, kind of feel like an idiot now. Sorry for the trouble
and thank you for your time!

Em ter, 28 de nov de 2023 18:22, Deif Lou <bugzilla_noreply@kde.org>
escreveu:

> https://bugs.kde.org/show_bug.cgi?id=477647
>
> Deif Lou <ginoba@gmail.com> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>              Status|NEEDSINFO                   |RESOLVED
>          Resolution|WAITINGFORINFO              |INTENTIONAL
>
> --- Comment #7 from Deif Lou <ginoba@gmail.com> ---
> It took me a while to decipher the situation, but I think I got it.
> The reason is that you have the  "Stop growing at the darkest and/or more
> opaque pixels" option on. When dealing with colored lines this option
> assumes
> that the the lines are darker than the inside area (hence the "stop at
> darkest
> pixels" part). So in the case of using the merged layers as reference, you
> have
> gray inside and white line, so the growing stops when reaching the line,
> since
> the pixels start to be lighter. In the case of lighter lines you have to
> use
> the other method with transparent, otherwise it does not grow. This is
> expected.
>
> --
> You are receiving this mail because:
> You reported the bug.