Bug 477632 - Preview disappears after Image Editor
Summary: Preview disappears after Image Editor
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Preview-Image (show other bugs)
Version: 8.1.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-27 18:10 UTC by Michael
Modified: 2023-11-28 21:36 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 8.2.0
Sentry Crash Report:


Attachments
Debug Log (8.88 KB, text/plain)
2023-11-27 18:10 UTC, Michael
Details
Report of locked file (9.64 KB, image/png)
2023-11-27 18:12 UTC, Michael
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael 2023-11-27 18:10:28 UTC
Created attachment 163549 [details]
Debug Log

SUMMARY
***
After editing an image the preview of the image disappears
***


STEPS TO REPRODUCE
1. View Preview
2. Select Image
3. Image Editor
3.1. Modify Image
3.2 . Save Changes

OBSERVED RESULT
The preview of the image disappears

EXPECTED RESULT
The preview show updated content of image

SOFTWARE/OS VERSIONS
Windows: Windows 10 Version 2009 (x86_64)

ADDITIONAL INFORMATION

The preview shows the expected content after restarting the app.
Comment 1 Michael 2023-11-27 18:12:09 UTC
Created attachment 163550 [details]
Report of locked file
Comment 2 Maik Qualmann 2023-11-27 20:05:09 UTC
I am aware of the problem with PGF files under Windows. But I think it is a problem within libpgf that a file handler is not closed. But I'll test it again in a few days.
Although we use PGF files as thumbnails, an image file is rarely used.

Maik
Comment 3 Maik Qualmann 2023-11-28 11:33:38 UTC
Git commit 250d69eaa5ccfaf353dad98f68748d36976387f2 by Maik Qualmann.
Committed on 28/11/2023 at 12:32.
Pushed by mqualmann into branch 'master'.

adjust share flags for creating PGF images

M  +2    -1    core/dplugins/dimg/pgf/dimgpgfloader_save.cpp

https://invent.kde.org/graphics/digikam/-/commit/250d69eaa5ccfaf353dad98f68748d36976387f2
Comment 4 Maik Qualmann 2023-11-28 21:04:38 UTC
Git commit 3f7879a62c2a9e6e1ad99abd4af8d6930a88e9e1 by Maik Qualmann.
Committed on 28/11/2023 at 22:03.
Pushed by mqualmann into branch 'master'.

add function for closing the PGF file handle

M  +15   -0    core/dplugins/dimg/pgf/dimgpgfloader.cpp
M  +2    -0    core/dplugins/dimg/pgf/dimgpgfloader.h
M  +14   -30   core/dplugins/dimg/pgf/dimgpgfloader_load.cpp
M  +3    -19   core/dplugins/dimg/pgf/dimgpgfloader_save.cpp

https://invent.kde.org/graphics/digikam/-/commit/3f7879a62c2a9e6e1ad99abd4af8d6930a88e9e1
Comment 5 Maik Qualmann 2023-11-28 21:20:52 UTC
Git commit 917e8004f39633ddf3b196b6e7f334698c68ce6f by Maik Qualmann.
Committed on 28/11/2023 at 22:19.
Pushed by mqualmann into branch 'master'.

fix missing file close in the loadPGFScaled() function
FIXED-IN: 8.2.0

M  +25   -0    core/libs/pgfutils/pgfutils.cpp
M  +0    -1    core/libs/pgfutils/pgfutils.h

https://invent.kde.org/graphics/digikam/-/commit/917e8004f39633ddf3b196b6e7f334698c68ce6f
Comment 6 Maik Qualmann 2023-11-28 21:36:23 UTC
Git commit fcb0199dbe895940ff3f219ac3e7484736939769 by Maik Qualmann.
Committed on 28/11/2023 at 22:35.
Pushed by mqualmann into branch 'master'.

add special case, do not write to PGF with Exiv2,
this would destroy the file.

M  +7    -0    core/libs/metadataengine/engine/metaengine_p.cpp

https://invent.kde.org/graphics/digikam/-/commit/fcb0199dbe895940ff3f219ac3e7484736939769