Bug 477628 - Add mremap support for Solaris
Summary: Add mremap support for Solaris
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: general (other bugs)
Version First Reported In: 3.21.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Paul Floyd
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-27 17:12 UTC by Jakub Kulik
Modified: 2023-11-28 09:23 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
mremap support for Solaris (2.78 KB, patch)
2023-11-27 17:12 UTC, Jakub Kulik
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Kulik 2023-11-27 17:12:26 UTC
Created attachment 163544 [details]
mremap support for Solaris

Oracle Solaris SRU 45 (May 2022) introduced a new mremap syscall that behaves the same as on Linux. The attached patch adds support for it; without it, Valgrind fails to build when mremap is available with:

m_aspacemgr/aspacemgr-common.c:234:6: error: #error Unknown OS
  234 | #    error Unknown OS
      |

To be sure, I ran `build` and `test` on illumos/OpenIndiana (which doesn't have mremap syscall) and found no issues with this patch.
Comment 1 Paul Floyd 2023-11-28 09:23:36 UTC
commit 03180d4403b2b6e849d0a311584ed8b1e6528158

Mixed up the last two patches in my git commits, above ID should be the right one