Bug 477392 - In Desktop Effects Magnifier and Zoom are radio buttons
Summary: In Desktop Effects Magnifier and Zoom are radio buttons
Status: RESOLVED INTENTIONAL
Alias: None
Product: kwin
Classification: Plasma
Component: effects-various (other bugs)
Version First Reported In: 5.27.9
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-11-22 23:19 UTC by Justin Zobel
Modified: 2023-11-23 09:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Zobel 2023-11-22 23:19:47 UTC
SUMMARY
While these are mutually exclusive effects, you can turn them off. Therefore, radio buttons seem like the incorrect choice?

Operating System: Fedora Linux 39
KDE Plasma Version: 5.81.80
KDE Frameworks Version: 5.245.0
Qt Version: 6.6.0
Kernel Version: 6.5.11-300.fc39.x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 12 × AMD Ryzen 5 3600 6-Core Processor
Memory: 31.3 GiB of RAM
Graphics Processor: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2
Comment 1 guimarcalsilva 2023-11-23 00:18:48 UTC
Hmm, this is also true on 5.27. Talking about the bug itself, I believe radio buttons are the right choice because both effects have a similar purpose and also use the same shortcuts. Enabling both at the same time would cause issues. Let's see what a developer thinks.
Comment 2 Justin Zobel 2023-11-23 03:45:07 UTC
To me, radio buttons means one or the other must be used, x or y and one must be selected.

This is not the case. Checkboxes would suit better and when one is toggled on, the other is greyed out.

Another option would be to place them in a container that is called something like Magnification Assistance. This would have a checkbox to say you want it, then the two options as radio buttons in there to choose the one you prefer.
Comment 3 David Edmundson 2023-11-23 09:04:36 UTC
If we had checkboxes we would have reports with:

"These are mutually exclusive effects, you cannot enable two. Therefore, checkboxes seem like the incorrect choice?".
I do recall it being discussed heavily at the time, it's intentional.

The UX isn't great, but a switch to checkboxes just makes a different problem. 

Ultimately we need to invert this on it's head and present the user with "close effect" and then a combo box where none is an option. Instead of presenting it as plugins.
Comment 4 Justin Zobel 2023-11-23 09:16:00 UTC
What about the other option. Combine the effects into a Magnification Assistant effect and then in the Settings the user chooses the style of magnification?