Bug 477303 - Text doesn't fit in "Configure Icons and Toolbars" pop-up in many languages
Summary: Text doesn't fit in "Configure Icons and Toolbars" pop-up in many languages
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_style (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-11-20 22:32 UTC by guimarcalsilva
Modified: 2023-11-27 02:10 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/-/commit/25085db1eb22db74c771dfe8de86d7b10266ba33
Version Fixed In:
Sentry Crash Report:

Attachments
Cutoff text (105.05 KB, image/png)
2023-11-20 22:32 UTC, guimarcalsilva 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description guimarcalsilva 2023-11-20 22:32:34 UTC 
Created attachment 163329 [details]
Cutoff text

SUMMARY
The "Configure Icons and Toolbars"  pop-up in kcm_style is too small to fit all the text in many languages. Some of the affected languages include French, Catalan, Portuguese, Danish and Italian.

STEPS TO REPRODUCE
1. Run 'LANGUAGE=pt_BR kcmshell6 kcm_style'
2. Click on the button on the header that corresponds to "Configure Icons and Toolbars"

OBSERVED RESULT
The text is too large to fit a small pop-up

EXPECTED RESULT
Pop-up resizes to fit

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.81.80
KDE Frameworks Version: 5.245.06.6.0
Qt Version: 

ADDITIONAL INFORMATION
Resizing the window doesn't help
Comment 1 guimarcalsilva 2023-11-20 22:35:02 UTC 
Oops, the correct Frameworks version is 5.245.0
Comment 2 Paolo Zamponi 2023-11-22 17:23:50 UTC 
Can confirm.
Comment 3 Nate Graham 2023-11-27 02:08:00 UTC 
Can reproduce with `LANGUAGE=pt_BR systemsettings kcm_style`. I see the problem; will fix.
Comment 4 Nate Graham 2023-11-27 02:10:49 UTC 
Git commit 25085db1eb22db74c771dfe8de86d7b10266ba33 by Nate Graham.
Committed on 27/11/2023 at 03:10.
Pushed by ngraham into branch 'master'.

kcms/style: Make "Configure Icons and Toolbars" popup fit wide content

Previously it was just hardcoded, which is not appropriate when
variable-length text is involved. To fix it, take into account the
implicit size of the content to determine the popup's size. Also include
a bit of padding so the content doesn't feel completely scrunched up
against the edges of the popup.

M  +4    -2    kcms/style/ui/EffectSettingsPopup.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/25085db1eb22db74c771dfe8de86d7b10266ba33