Bug 477271 - QQC Menu has excessive empty area
Summary: QQC Menu has excessive empty area
Status: RESOLVED FIXED
Alias: None
Product: frameworks-qqc2-desktop-style
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.245.0
Platform: openSUSE Other
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords: qt6, regression
Depends on:
Blocks:
 
Reported: 2023-11-20 08:01 UTC by Fushan Wen
Modified: 2023-11-20 16:57 UTC (History)
4 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/qqc2-desktop-style/-/commit/89b75b641ae69a504d4b64e56bb28f94b0a5762c
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Fushan Wen 2023-11-20 08:01:18 UTC 
STEPS TO REPRODUCE
1. Open widget config dialog
2. Go to About page
3. Open the license sheet
4. Right click the license sheet

OBSERVED RESULT
Excessive empty area

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: qqc2-desktop-style at 619a24bfe6a859ef79ef990e65b875887edae1e9
Qt Version: 6.6.0

ADDITIONAL INFORMATION
Regression since https://invent.kde.org/frameworks/qqc2-desktop-style/-/commit/31701c279f919d000e9b67d84526790a55feb32d
Comment 1 Bug Janitor Service 2023-11-20 14:16:17 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/327
Comment 2 Arjen Hiemstra 2023-11-20 16:57:10 UTC 
Git commit 89b75b641ae69a504d4b64e56bb28f94b0a5762c by Arjen Hiemstra.
Committed on 20/11/2023 at 15:16.
Pushed by ahiemstra into branch 'master'.

menuitem: Re-add a binding to reduce height to 0 when invisible

This used to be part of the implicitHeight binding but since that was
cleaned up it broke. Instead of re-adding it to the implicitHeight, now
add it as a binding on explicit height along with a comment.

M  +3    -0    org.kde.desktop/MenuItem.qml

https://invent.kde.org/frameworks/qqc2-desktop-style/-/commit/89b75b641ae69a504d4b64e56bb28f94b0a5762c