Bug 477266 - Title bar does not turn dark when Windows is set to Dark mode
Summary: Title bar does not turn dark when Windows is set to Dark mode
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: 5.2.1
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Alvin Wong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-20 05:33 UTC by j6776875
Modified: 2023-11-20 08:47 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Screenshot showing Krita alongside other programs on Windows 11 in Dark mode (349.82 KB, image/png)
2023-11-20 05:33 UTC, j6776875
Details

Note You need to log in before you can comment on or make changes to this bug.
Description j6776875 2023-11-20 05:33:30 UTC
Created attachment 163308 [details]
Screenshot showing Krita alongside other programs on Windows 11 in Dark mode

SUMMARY
When using the Dark mode feature built into Windows, the title bar of Krita does not properly change to match, unlike other Windows apps.

STEPS TO REPRODUCE
1. Set Windows 11 to Dark mode.
2. Open Krita.

OBSERVED RESULT
Title bar is white.

EXPECTED RESULT
Title bar is dark grey or black.

SOFTWARE/OS VERSIONS
Windows: Windows 11 23H2

ADDITIONAL INFORMATION
Attached screenshot shows Krita 5.2.1 in comparison to Inkscape 1.3.1, Microsoft Paint, and Clip Studio Paint 2.2.2 in Dark mode on Windows 11.
Comment 1 Alvin Wong 2023-11-20 08:46:34 UTC
Git commit e5561dc9bf988185b0dc407926d04f79180c90d6 by Alvin Wong.
Committed on 20/11/2023 at 09:46.
Pushed by alvinwong into branch 'master'.

windows: Enable dark mode title bar with `darkmode=1`

Ask Qt to switch the window frame to black when "application dark mode"
is enabled in Windows settings. This does not affect and is not affected
by the in-application theme selection.

M  +1    -1    krita/main.cc

https://invent.kde.org/graphics/krita/-/commit/e5561dc9bf988185b0dc407926d04f79180c90d6
Comment 2 Alvin Wong 2023-11-20 08:47:10 UTC
Git commit 4ad5ab2190a8da725eb76ce5445f948bcf424a3f by Alvin Wong.
Committed on 20/11/2023 at 09:46.
Pushed by alvinwong into branch 'krita/5.2'.

windows: Enable dark mode title bar with `darkmode=1`

Ask Qt to switch the window frame to black when "application dark mode"
is enabled in Windows settings. This does not affect and is not affected
by the in-application theme selection.
(cherry picked from commit e5561dc9bf988185b0dc407926d04f79180c90d6)

M  +1    -1    krita/main.cc

https://invent.kde.org/graphics/krita/-/commit/4ad5ab2190a8da725eb76ce5445f948bcf424a3f