Bug 477184 - The sidebar item in the widget config dialog no longer gets highlighted
Summary: The sidebar item in the widget config dialog no longer gets highlighted
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: general (show other bugs)
Version: master
Platform: openSUSE Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: qt6, regression
: 472668 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-11-18 13:27 UTC by Fushan Wen
Modified: 2023-12-03 00:12 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-desktop/-/commit/739cfe66fbc514502d53d59281522cf2becfd851
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Patrick Silva 2023-11-18 13:56:04 UTC 
duplicate of bug 472668 ?
Comment 2 Bug Janitor Service 2023-11-18 16:24:46 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1841
Comment 3 Nicolas Fella 2023-11-24 11:52:35 UTC 
Git commit 739cfe66fbc514502d53d59281522cf2becfd851 by Nicolas Fella.
Committed on 24/11/2023 at 12:47.
Pushed by nicolasfella into branch 'master'.

Fix highlighting current item in applet config

We try to compare the current item's source to the model, but we can't actually get the source from the item or the pageStack

Instead manually keep track of the current source to compare

Also always resolve the relative input URLs to simplify comparison and unify the code for applets and containments

M  +9    -7    desktoppackage/contents/configuration/AppletConfiguration.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/739cfe66fbc514502d53d59281522cf2becfd851
Comment 4 Patrick Silva 2023-12-03 00:12:32 UTC 
*** Bug 472668 has been marked as a duplicate of this bug. ***