Created attachment 163179 [details] kgraphviewer screenshot SUMMARY *** NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols. See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports *** Whenever I open a dot file, it's rendered with tamil fonts, and I get this in the console output: ``` org.kde.kgraphviewer.lib: Unknown DOT font ' "" '. returning Qt default. ``` If I edit the dot file and add e.g.: ``` node [fontname="notomono"]; edge [fontname="notomono"]; ``` then I can properly see it. This is particularly annoying when working with massif-visualizer, which generates the callgraph on the fly. STEPS TO REPRODUCE 1. 2. 3. OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Windows: macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION
It works properly with: ``` diff --git a/src/part/dot2qtconsts.cpp b/src/part/dot2qtconsts.cpp index c600f70..91d7515 100644 --- a/src/part/dot2qtconsts.cpp +++ b/src/part/dot2qtconsts.cpp @@ -24,6 +24,7 @@ #include <QColor> #include <QDebug> +#include <qapplication.h> const Dot2QtConsts Dot2QtConsts::m_componentData; @@ -841,6 +842,9 @@ Dot2QtConsts::Dot2QtConsts() i++; } + // Add a default font too + m_psFonts[""] = QApplication::font(); + uint j = 0; while (color_lib[j].name) { // () << "Adding color " << color_lib[j].name; ```
Git commit acb5fec4e9614324acdbc4cfce4f387df65bd0f4 by Friedrich W. H. Kossebau. Committed on 16/04/2024 at 09:16. Pushed by kossebau into branch 'master'. Fix bad defaults for fonts, also for colors, shapes & style The refactoring started in 117f22918f594a046e8e541701a3cd863539cdd0 seems to have missed out follow-up work to ensure defaults are used where not set explicitly, as before. e47e5ae6d38c0e16b90714f1887b827a009999d4 later only ensured explicit default font size values exist. Dot2QtConsts covers many of the defaults indirectly. For QFont though it was using "" as fort family name, which resulted in random fonts being picked by Qt. The implementation now avoids adding explicit attribute instances, but instead returns default values if not set, for less runtime memory usage. Related: bug 470523 FIXED-IN: 2.5.0 M +59 -11 src/part/graphelement.cpp M +7 -28 src/part/graphelement.h https://invent.kde.org/graphics/kgraphviewer/-/commit/acb5fec4e9614324acdbc4cfce4f387df65bd0f4