Bug 476898 - With certain languages, in widescreen view, clicking a card on the home page causes cards in cards list to overflow
Summary: With certain languages, in widescreen view, clicking a card on the home page ...
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: master
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: qt6, regression
: 477634 477823 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-11-12 21:18 UTC by guimarcalsilva
Modified: 2024-01-29 17:24 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0
Sentry Crash Report:


Attachments
Cards do not resize to fit (351.36 KB, image/png)
2023-11-12 21:18 UTC, guimarcalsilva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description guimarcalsilva 2023-11-12 21:18:27 UTC
Created attachment 163091 [details]
Cards do not resize to fit

SUMMARY
The card elements overflow on the Home page when the app page is open. Check the attached screenshot.

STEPS TO REPRODUCE
1. Be on the Home page
2. Click on an application

OBSERVED RESULT
The app page opens to the right, but the cards on the Home page do not get resized and as such go under the scrollbar

EXPECTED RESULT
Cards resize to fit the space

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.81.0
KDE Frameworks Version: 5.245.0
Qt Version: 6.6.0

ADDITIONAL INFORMATION
Screen resolution: 1280x800 (On a VM)
Comment 1 Nate Graham 2023-11-14 23:17:34 UTC
Cannot reproduce. For me the list always disappears before it becomes small enough to cut off content.

if you de-maximize the window and manually increase its size, do you still encounter this issue?
Comment 2 guimarcalsilva 2023-11-15 00:52:42 UTC
(In reply to Nate Graham from comment #1)
> Cannot reproduce. For me the list always disappears before it becomes small
> enough to cut off content.
> 
> if you de-maximize the window and manually increase its size, do you still
> encounter this issue?

Yes, I still see the issue. I think I found the cause, though. It's related to the language. I tested with English, French, German, and Spanish, and there's no problem, but it is a problem with European/Brazilian Portuguese. I also saw the problem with Catalan and Danish but since my base system is in PT it's possible they might not have all strings translated and as such might be "contaminated" by PT strings. I tried setting the system to English and then running Discover with the LANGUAGE= env variable but then Discover didn't get translated at all for some reason, so I couldn't really test if Calatan and Danish are also affected.
Comment 3 guimarcalsilva 2023-11-15 00:55:20 UTC
>Yes, I still see the issue. I think I found the cause, though. It's related to the language. I tested with English, French, German, and Spanish, and there's no problem, but it is a problem with European/Brazilian Portuguese. I also saw the problem with Catalan and Danish but since my base system is in PT it's possible they might not have all strings translated and as such might be "contaminated" by PT strings. I tried setting the system to English and then running Discover with the LANGUAGE= env variable but then Discover didn't get translated at all for some reason, so I couldn't really test if Calatan and Danish are also affected.

Just adding something I forgot to say: Yes, I did try installing the language packs for those languages but Discover was still in English. Either way, that's another issue entirely. The gist of it is that the problem does seem to be related to text in some languages.
Comment 4 Nate Graham 2023-11-16 22:28:17 UTC
Hmm, cannot reproduce the issue when running with `LANG=pt_BR plasma-discover`
Comment 5 guimarcalsilva 2023-11-20 22:05:37 UTC
(In reply to Nate Graham from comment #4)
> Hmm, cannot reproduce the issue when running with `LANG=pt_BR
> plasma-discover`

That's odd. I can reproduce it even on a fresh Live booted system. Did you use the right env variable? The correct one is LANGUAGE=pt_BR. Also, make sure to do it on the "Home" page, not the "All Applications" page. The bug is only present on the Home page. Additionally, on Neon, the only backend available is Flathub, all others don't seem to show apps on the Home page, so that might also be a contributing factor (unlikely, but I've run out of ideas :P).
Comment 6 Nate Graham 2023-11-20 22:10:26 UTC
Ahh, only from the home page. Sorry for being dense and missing the important part. Can now reproduce in all languages tested.
Comment 7 Nate Graham 2023-11-28 21:01:35 UTC
*** Bug 477634 has been marked as a duplicate of this bug. ***
Comment 8 Patrick Silva 2023-12-01 13:31:56 UTC
*** Bug 477823 has been marked as a duplicate of this bug. ***
Comment 9 Nate Graham 2024-01-18 22:42:03 UTC
*** Bug 477493 has been marked as a duplicate of this bug. ***
Comment 10 Bug Janitor Service 2024-01-19 00:43:12 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/735
Comment 11 Nate Graham 2024-01-19 04:11:19 UTC
Git commit 7b3771cb08ec4290a902489e9fd7f8e36d2d2e62 by Nate Graham.
Committed on 19/01/2024 at 05:09.
Pushed by ngraham into branch 'master'.

Home page: span and wrap title labels

Otherwise in some languages, the label object will overflow the view
when it's very narrow, as in widescreen mode when clicking on one of the
apps on the page.

To prevent this, make the labels fill width and wrap.
FIXED-IN: 6.0

M  +10   -0    discover/qml/BrowsingPage.qml

https://invent.kde.org/plasma/discover/-/commit/7b3771cb08ec4290a902489e9fd7f8e36d2d2e62
Comment 12 Nate Graham 2024-01-19 04:11:43 UTC
Git commit ff7aaf9f4c54a4146c7d435f75e530d105aa30df by Nate Graham.
Committed on 19/01/2024 at 05:11.
Pushed by ngraham into branch 'Plasma/6.0'.

Home page: span and wrap title labels

Otherwise in some languages, the label object will overflow the view
when it's very narrow, as in widescreen mode when clicking on one of the
apps on the page.

To prevent this, make the labels fill width and wrap.
FIXED-IN: 6.0


(cherry picked from commit 7b3771cb08ec4290a902489e9fd7f8e36d2d2e62)

M  +10   -0    discover/qml/BrowsingPage.qml

https://invent.kde.org/plasma/discover/-/commit/ff7aaf9f4c54a4146c7d435f75e530d105aa30df
Comment 13 Patrick Silva 2024-01-29 12:37:19 UTC
Duplicate bug 477493 is still reproducible on neon unstable.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 6.0.80
KDE Frameworks Version: 5.249.0
Qt Version: 6.6.1
Graphics Platform: Wayland
Comment 14 Nate Graham 2024-01-29 17:24:31 UTC
Right you are. I un-marked it as a duplicate.