Everything from today's git master Plasma 6 Wayland. STEPS TO REPRODUCE 1. Open Kickoff 2. Search for "Dolphin" 3. Right-click on the search result for the Dolphin app OBSERVED RESULT There's no menu item "Add to Favorites" (or "Remove from Favorites", if it's already a favorite) EXPECTED RESULT There is a menu item for "Add to Favorites"
*** Bug 477300 has been marked as a duplicate of this bug. ***
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3579
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1859
Git commit f295d43d4af47d89ebf1a74c06bf74405f6ae428 by Nate Graham, on behalf of Bharadwaj Raju. Committed on 30/11/2023 at 16:58. Pushed by ngraham into branch 'master'. applets/kicker: Handle `undefined` values of favoritesModel/favoriteId correctly Prevents spurious "Add to Favorites" items from showing up in the context menus of things that can't actually be favorited. To be applied with https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3559. M +1 -1 applets/kicker/package/contents/ui/code/tools.js https://invent.kde.org/plasma/plasma-desktop/-/commit/f295d43d4af47d89ebf1a74c06bf74405f6ae428
Git commit 6b499a743cadc0bae97509a97cf4aaef69cced82 by Nate Graham, on behalf of Kai Uwe Broulik. Committed on 30/11/2023 at 17:16. Pushed by ngraham into branch 'master'. kicker: Forward favoritesModel to RunnerMatchesModel Kickoff uses the model's favoritesModel in the delegate to add/remove favorites. RunnerModel has it but the individual RunnerMatchesModel it displays did not, breaking the favorites functionality in Kickoff's search. M +13 -0 applets/kicker/plugin/runnermatchesmodel.cpp M +9 -0 applets/kicker/plugin/runnermatchesmodel.h M +8 -1 applets/kicker/plugin/runnermodel.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/6b499a743cadc0bae97509a97cf4aaef69cced82