Bug 476577 - Setting maximum recent files to 0 still stores 1 file
Summary: Setting maximum recent files to 0 still stores 1 file
Status: RESOLVED FIXED
Alias: None
Product: Haruna
Classification: Applications
Component: generic (other bugs)
Version First Reported In: 0.12.1
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: george fb
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-05 10:47 UTC by Austin Keeton
Modified: 2023-11-05 19:59 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Shows the settings and harunarc (174.21 KB, image/png)
2023-11-05 10:47 UTC, Austin Keeton
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Austin Keeton 2023-11-05 10:47:37 UTC
Created attachment 162878 [details]
Shows the settings and harunarc

SUMMARY
In Settings > General the "Maximum recent files" can be set to 0. After watching a video, File > Recent Files is empty, however .config/harunarc shows the recent video and url. Watching a subsequent video does not update the entry.

STEPS TO REPRODUCE
1. In Settings > General, set "Maximum recent files" to 0.
2. Watch a video
3. View the File > Recent menu. There are no entries.
4. View .config/harunarc. The file name and url of the video is listed.
5. Watch a different video.
6. File > Recent is still empty.
7. The file and url from the first video remains the same.

OBSERVED RESULT
.config/harunarc shows the file and url of the first video watched.

EXPECTED RESULT
.config/harunarc should not show any file or url history

SOFTWARE/OS VERSIONS
Linux Kernel: 6.5.0-10-generic (64-bit)
KDE Plasma Version: 5.27.8
KDE Frameworks Version: 5.110.0
Qt Version: 5.15.10

ADDITIONAL INFORMATION
Comment 1 george fb 2023-11-05 11:00:10 UTC
That is the intended behaviour. If you click clear it will remove them from the config file and won't add other files.

I will change it to remove the files from the config when setting the value to 0.
Comment 2 Austin Keeton 2023-11-05 11:06:41 UTC
Thank you, but maybe I wasn't clear in my description because it doesn't seem like intended behavior. Let me try again:

1. Both File > Recent and .config/harunarc do not show any files or urls
2. Set the Maximum recent files to 0
3. Watch a video and close Haruna
4. File > Recent remains empty
5. .config/harunarc now shows the file and url

It seems like since harunarc had no history to begin with that it shouldn't have added an entry at all.
Comment 3 george fb 2023-11-05 11:21:02 UTC
Try version  0.12.2, I can't reproduce.
Comment 4 Austin Keeton 2023-11-05 19:59:28 UTC
Upgrading to 0.12.2 fixed the issue. I apologize for the trouble.