Bug 476392 - Scanning music popup text is not aligned nicely
Summary: Scanning music popup text is not aligned nicely
Status: RESOLVED FIXED
Alias: None
Product: Elisa
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-01 04:23 UTC by Justin Zobel
Modified: 2023-11-01 23:35 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Screenshot (105.13 KB, image/png)
2023-11-01 04:23 UTC, Justin Zobel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Zobel 2023-11-01 04:23:41 UTC
Created attachment 162781 [details]
Screenshot

Text is not vertically centred, which looks unpolished.
Comment 1 Nate Graham 2023-11-01 20:09:32 UTC
I assume you're building with current git master? Because I changed this artound on October 29th in 85bcddd66143b39422a4f9c04953e851fb7af682, and the label is vertically centered.
Comment 2 Nate Graham 2023-11-01 20:13:08 UTC
Ahh, found it. The label is vertically centered, but also has `Layout.fillHeight: true` set, which renders the alignment moot. We need to set the alignment on the text *within* the label when using fillHeight. Or we can just not fill height and let the alignment of the entire item work as intended.
Comment 3 Nate Graham 2023-11-01 20:15:11 UTC
Git commit 8519026989f30288d8eb0aa08d4674bb00ecdc63 by Nate Graham.
Committed on 01/11/2023 at 21:13.
Pushed by ngraham into branch 'master'.

Properly align text in track import notification

We were setting the alignment but also filling height, which renders
vertical alignment moot. Instead, set the alignment on the text in the
Label item, not the Label item itself.

M  +1    -1    src/qml/TrackImportNotification.qml

https://invent.kde.org/multimedia/elisa/-/commit/8519026989f30288d8eb0aa08d4674bb00ecdc63
Comment 4 Justin Zobel 2023-11-01 23:35:29 UTC
I was running a released version but I couldn't tell you what version because there's no about option on mobile for Elisa (separate bug filed about that already).