Bug 476285 - Post language names are in English
Summary: Post language names are in English
Status: RESOLVED FIXED
Alias: None
Product: Tokodon
Classification: Applications
Component: general (show other bugs)
Version: 23.08.2
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Unassigned bugs mailing-list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-29 11:29 UTC by Emir SARI
Modified: 2023-11-05 23:54 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Emir SARI 2023-10-29 11:29:02 UTC
Steps:

- Use a language other than English, and has Tokodon fully translated
- Open Tokodon
- Write a new post
- Click on the language drop-down

Expected:
- Translated language names

Actual:
- English language names
Comment 1 Joshua Goins 2023-10-29 14:13:43 UTC
We get the names from Qt, but I'm sure there's a way to get non-english names out of it. What's the ideal format here, the native language name maybe? Something like, "Deutsch" and "日本語"?
Comment 2 Emir SARI 2023-10-29 18:59:24 UTC
Yes, original names would be the way to go.
Comment 3 Joshua Goins 2023-11-05 23:54:38 UTC
Git commit 6511c9d8b42fc81e1788e12a60fce3b5ed66d7ec by Joshua Goins.
Committed on 06/11/2023 at 00:49.
Pushed by redstrate into branch 'master'.

Overhaul language selector

Now it's an OverlaySheet which is way less hacky than our custom
ComboBox reimplementation, and comes with more fringe benefits. For one,
native language names are used if available to us. Another is the
selected language is now presented in the center of the selection, so
you don't lose the selection. KItemModels is used instead of us having
another reimplementation of it.

M  +34   -54   src/content/ui/LanguageSelector.qml
M  +11   -10   src/content/ui/Settings/ProfileEditor.qml
M  +7    -5    src/content/ui/StatusComposer/StatusComposer.qml
M  +16   -23   src/editor/languagemodel.cpp
M  +2    -17   src/editor/languagemodel.h

https://invent.kde.org/network/tokodon/-/commit/6511c9d8b42fc81e1788e12a60fce3b5ed66d7ec