Bug 476150 - Error messages in "Get new" dialogs are too narrow
Summary: Error messages in "Get new" dialogs are too narrow
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR minor
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords: qt6, usability
Depends on:
Blocks:
 
Reported: 2023-10-27 13:17 UTC by Patrick Silva
Modified: 2023-11-03 19:12 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6
Sentry Crash Report:


Attachments
screenshot (153.21 KB, image/png)
2023-10-27 13:17 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2023-10-27 13:17:38 UTC
Created attachment 162591 [details]
screenshot

SUMMARY
"Get new" dialogs frequently show error messages when searching or selecting a filter on top.
As we can see in the attached screenshot, these error messages are too narrow, and the title is elided.

EXPECTED RESULT
error messages with sane sizes

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.240.0
Qt Version: 6.6.0
Graphics Platform: Wayland
Comment 1 Nate Graham 2023-10-27 15:59:50 UTC
Unusually enough, I'm not able to make any error messages appear right now like I usually can.
Comment 2 Bug Janitor Service 2023-11-03 18:42:36 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/knewstuff/-/merge_requests/281
Comment 3 Ismael Asensio 2023-11-03 19:12:19 UTC
Git commit 01130b6f5618cde7f6580be9b5ed79143ed695cc by Ismael Asensio.
Committed on 03/11/2023 at 20:02.
Pushed by iasensio into branch 'master'.

QML: Simplify Error Message and fix its dimensions

We have Kirigami.PromptDialog now, so no need to generate a custom
MessageBoxSheet. This is a more proper control for showing errors
and fixes the small dimensions of the previous versions.

While at it also use Kirigami.SelectableLabel, remove import versions,
and fix the link signal handler by setting and explicit argument.
FIXED-IN: 6

M  +0    -1    src/qtquick/CMakeLists.txt
M  +42   -19   src/qtquick/qml/private/ErrorDisplayer.qml
D  +0    -52   src/qtquick/qml/private/MessageBoxSheet.qml

https://invent.kde.org/frameworks/knewstuff/-/commit/01130b6f5618cde7f6580be9b5ed79143ed695cc