Bug 476096 - Test popup overflow with a single Mono channel
Summary: Test popup overflow with a single Mono channel
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_pulseaudio (other bugs)
Version First Reported In: 5.27.9
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-25 20:42 UTC by ratijas
Modified: 2024-07-24 12:40 UTC (History)
4 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-pa/-/commit/d2b7b6a0c524ba50529a319a9a9e97a0c1c7137c
Version Fixed/Implemented In: 6.1.4
Sentry Crash Report:

Attachments
UI overflow (25.72 KB, image/png)
2023-10-25 20:42 UTC, ratijas 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description ratijas 2023-10-25 20:42:12 UTC 
Created attachment 162570 [details]
UI overflow

SUMMARY

The title says it. Just look at the screenshot.

STEPS TO REPRODUCE
1. Connect Bluetooth headset, select "Headset Head Unit (HSP/HFP)" profile;
2. Tap "Test" button.

OBSERVED RESULT
UI of the popup dialog does not fit horizontally. Some of it overflows (title), and some of it clips without scrolling (content).

EXPECTED RESULT
1. Some sane minimum width for the popup;
2. Elided title with tooltip if needed;
3. Horizontal scrolling if absolutely needed.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.240.0
Qt Version: 6.6.0
Kernel Version: 6.5.8-arch1-1 (64-bit)
Graphics Platform: X11
Comment 1 Nate Graham 2023-10-26 21:50:48 UTC 
Yikes
Comment 2 Bug Janitor Service 2024-06-09 13:12:28 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-pa/-/merge_requests/265
Comment 3 Ismael Asensio 2024-07-24 12:35:04 UTC 
Git commit f3645de33420a7f56840f7693689ba9ae2d02a8f by Ismael Asensio.
Committed on 24/07/2024 at 12:35.
Pushed by iasensio into branch 'master'.

kcm/SpeakerTest: Fix the minimum layout for Mono channel

The label needs to set `fillWidth: true` to influence the sheet's
minimum width, so it doesn't get cut out.

This is only noticeable when the grid layout is smaller, when we
have single `Mono` channel. Also slightly adjust the Grid's sizes
and alignment for that case

|BEFORE|AFTER|
|---|---|
|![Screenshot_20240609_030728](/uploads/df8020761ddb0d4e6aec88df69e499ae/Screenshot_20240609_030728.png)|![Screenshot_20240609_025443](/uploads/5eb0b16b1decc2157bdba5a90cc5c336/Screenshot_20240609_025443.png)|
FIXED-IN: 6.1

M  +18   -2    src/kcm/ui/main.qml

https://invent.kde.org/plasma/plasma-pa/-/commit/f3645de33420a7f56840f7693689ba9ae2d02a8f
Comment 4 Ismael Asensio 2024-07-24 12:40:16 UTC 
Git commit d2b7b6a0c524ba50529a319a9a9e97a0c1c7137c by Ismael Asensio.
Committed on 24/07/2024 at 12:38.
Pushed by iasensio into branch 'Plasma/6.1'.

kcm/SpeakerTest: Fix the minimum layout for Mono channel

When we have single `Mono` channel, the sheet's minimum width would get
smaller than the hint label `implicitWidth`, messing up the layout and
cutting some items out of view

Add some spacer items to the grid view so a better width is reserved
and also set this label's properties to wrap and center correctly.
FIXED-IN: 6.1.4

(cherry picked from commit 3182f64b841a48f4b25f87c24b6ce0f8aa3ef0ea)

M  +18   -2    src/kcm/ui/main.qml

https://invent.kde.org/plasma/plasma-pa/-/commit/d2b7b6a0c524ba50529a319a9a9e97a0c1c7137c