Bug 475947 - Spellcheck for subtitles places corrections at the end
Summary: Spellcheck for subtitles places corrections at the end
Status: CONFIRMED
Alias: None
Product: kdenlive
Classification: Applications
Component: Title Clips & Subtitles (other bugs)
Version First Reported In: 23.08.1
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Ron
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-22 01:46 UTC by Jarno van der Kolk
Modified: 2025-05-23 00:09 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jarno van der Kolk 2023-10-22 01:46:10 UTC
SUMMARY
When editing subtitles in Kdenlive, spelling errors are correctly underlined. Right-clicking on those words correctly shows suggested correction. However, choosing on of those corrections always placed the correction at the very end of the text box and it leaves the original misspelled word in place.

STEPS TO REPRODUCE
1. Edit a subtitle
2. Make a spelling mistake in a sentence
3. Right-click on the misspelled word
4. Choose the correct spelling

OBSERVED RESULT
The correction appears at the very end of the text. The original misspelled word remains.

EXPECTED RESULT
The misspelled word should be replaced by the correction.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.27.8
KDE Frameworks Version: 5.111.0
Qt Version: 5.15.11

ADDITIONAL INFORMATION
N/A
Comment 1 Ron 2025-05-21 17:16:03 UTC
I can't reproduce this with current plasma.  Right clicking on "check spelling"
gives me a dialog with a 'replace' option, which if clicked correctly replaces
the word that was checked.

Do you still see this with current releases?
Comment 2 Jarno van der Kolk 2025-05-21 23:47:28 UTC
Yes that method you are using works for me too.

However, what I was referring to was the automatic spellcheck. If you enable that, you will get red underlined words for misspelled words. When you right click on one of those words, it will list a bunch of suggestions. Choosing one of those suggestions causes the original misspelled word to remain and the corrected word will be appended to the end of the text.

For completeness sake, I'm now on Kdenlive version 25.04.1.
KDE Plasma Version: 6.3.5
KDE Frameworks Version: 6.14.0
Qt Version: 6.9.0
Comment 3 Ron 2025-05-22 01:59:27 UTC
Ah, thanks for the clarification.  I can confirm that.

Though it also doesn't always do it ...  at least not in the code in my dev branch
which does already have other changes to the subtitle editor, including a few
regarding cursor position.  Sometimes it replaces the word as expected, and
sometimes it places the correction at the end.

Will look into it, thanks for catching and reporting this.
Comment 4 Jarno van der Kolk 2025-05-22 23:21:36 UTC
Interesting. Yeah you maybe already caught some if then. For me, I get it 100% of the time.
Comment 5 Ron 2025-05-23 00:09:00 UTC
It did for me at first too, until I started poking at correcting words in the middle of a sentence
and moving where the text cursor was when the correction was made - and I didn't see an
immediately obvious pattern as to when this bug did or didn't trigger.

There's some fancy footwork that goes on in the background which moves the cursor
around internally for various reasons, so my first blind guess is it's something to do with
it being in the wrong place when this fires.