Bug 475849 - Unnecessarily long size strings
Summary: Unnecessarily long size strings
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Flatpak Backend (show other bugs)
Version: master
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2023-10-19 20:27 UTC by Nate Graham
Modified: 2023-10-20 18:37 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2023-10-19 20:27:57 UTC
For Flatpak apps, Discover shows the download size as well as the installed-on-disk size. This presents a few issues:
- Most of the time the numbers are similar, or at least not different enough to meaningfully matter
- It takes up a lot of room on the header, and looks awkward
- It's inconsistent with the PackageKit backend, which doesn't do this even though the download size also differs from the installed size

So let's consider not showing the download size.
Comment 1 Bug Janitor Service 2023-10-19 20:40:01 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/663
Comment 2 Nate Graham 2023-10-20 18:37:46 UTC
Git commit 1aa5cbe0cc606592db970dbf51baed53ba74bb99 by Nate Graham.
Committed on 20/10/2023 at 20:36.
Pushed by ngraham into branch 'master'.

Don't show download size for Flatpak apps

- Most of the time the numbers are similar, or at least not different
  enough to meaningfully matter
- It takes up a lot of room on the header, and looks awkward
- It's inconsistent with the PackageKit backend, which doesn't do this
  even though the download size also differs from the installed size
FIXED-IN: 6.0

M  +7    -18   libdiscover/backends/FlatpakBackend/FlatpakResource.cpp

https://invent.kde.org/plasma/discover/-/commit/1aa5cbe0cc606592db970dbf51baed53ba74bb99