Bug 475842 - Screenshots never loading from Flathub beta
Summary: Screenshots never loading from Flathub beta
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: Flatpak Backend (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-19 19:47 UTC by Nate Graham
Modified: 2023-10-25 22:15 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0
Sentry Crash Report:


Attachments
No screenshots on Flathub beta (243.27 KB, image/jpeg)
2023-10-19 19:47 UTC, Nate Graham
Details
Screenshots on Flathub user (278.45 KB, image/jpeg)
2023-10-19 19:47 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2023-10-19 19:47:37 UTC
Created attachment 162432 [details]
No screenshots on Flathub beta

Plasma 6 git master, Wayland, 200% scale.


STEPS TO REPRODUCE
1. Install repos for Flathub user and Flathub beta
2. Restart the system just to be sure
3. Launch Discover
4. Find an app that's on both Flathub user and Flathub beta (e.g. Olive)
5. Switch source to Flathub beta


OBSERVED RESULT
All screenshot thumbnails fail to load


EXPECTED RESULT
All screenshots are there, just as if you were looking at it from the Flathub user source
Comment 1 Nate Graham 2023-10-19 19:47:57 UTC
Created attachment 162433 [details]
Screenshots on Flathub user
Comment 2 Bug Janitor Service 2023-10-24 08:17:39 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/676
Comment 3 Arjen Hiemstra 2023-10-24 15:36:16 UTC
Git commit 7c96e31f92e13c806e5f8351d2751cc05e415c75 by Arjen Hiemstra.
Committed on 24/10/2023 at 17:36.
Pushed by ahiemstra into branch 'master'.

Fallback to large image if thumbnail fails to load

There is already a fallback to large image for when the thumbnail is not
set. So add the same fallback for when the thumbnail fails to load. This
fixes a number of beta applications that seem to lack automatically
generated thumbnails.

M  +12   -0    discover/qml/CarouselInlineView.qml

https://invent.kde.org/plasma/discover/-/commit/7c96e31f92e13c806e5f8351d2751cc05e415c75