Bug 475696 - Enter/Return is broken in the clipboard widget
Summary: Enter/Return is broken in the clipboard widget
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Clipboard widget & pop-up (other bugs)
Version First Reported In: master
Platform: Compiled Sources Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: qt6, regression
Depends on:
Blocks:
 
Reported: 2023-10-16 13:40 UTC by Fushan Wen
Modified: 2023-10-19 01:02 UTC (History)
1 user (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/-/commit/fd5c0faee24aac222a71c061f3bb72482635e591
Version Fixed In: 6.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Fushan Wen 2023-10-16 13:40:12 UTC 
It still uses the nonexistent get method.

        switch(event.key) {
            case Qt.Key_Enter:
            case Qt.Key_Return: {
                if (clipboardMenu.view.currentIndex >= 0) {
                    var uuid = clipboardMenu.model.get(clipboardMenu.view.currentIndex).UuidRole
                    if (uuid) {
                        clipboardSource.service(uuid, "select")
                        if (main.hideOnWindowDeactivate) {
                            main.expanded = false;
                        }
                    }
                }
                break;
            }
Comment 1 Bug Janitor Service 2023-10-16 16:18:14 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3414
Comment 2 Fushan Wen 2023-10-18 17:31:30 UTC 
Git commit fd5c0faee24aac222a71c061f3bb72482635e591 by Fushan Wen.
Committed on 18/10/2023 at 19:29.
Pushed by fusionfuture into branch 'master'.

applets/clipboard: move Enter/Return handler to item
FIXED-IN: 6.0

M  +2    -0    applets/clipboard/contents/ui/ClipboardItemDelegate.qml
M  +0    -13   applets/clipboard/contents/ui/ClipboardPage.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/fd5c0faee24aac222a71c061f3bb72482635e591
Comment 3 Fushan Wen 2023-10-19 01:02:18 UTC 
Git commit 553d6f56c79dc6c135fa8ec8d557a4ae3a9dec0b by Fushan Wen.
Committed on 19/10/2023 at 02:51.
Pushed by fusionfuture into branch 'master'.

clipboardtest: consolidate fd5c0faee24aac222a71c061f3bb72482635e591

M  +1    -1    appiumtests/CMakeLists.txt
M  +71   -52   appiumtests/clipboardtest.py
M  +-    --    klipper/autotests/data/onetextentry.lst

https://invent.kde.org/plasma/plasma-workspace/-/commit/553d6f56c79dc6c135fa8ec8d557a4ae3a9dec0b