Bug 475694 - Shortcuts KCM shows "kded6" entry with generic icon
Summary: Shortcuts KCM shows "kded6" entry with generic icon
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kded
Classification: Frameworks and Libraries
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Neon Linux
: NOR minor
Target Milestone: ---
Assignee: KIO Bugs
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-10-16 12:51 UTC by Patrick Silva
Modified: 2024-01-25 14:26 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot (95.20 KB, image/png)
2023-10-16 12:51 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2023-10-16 12:51:24 UTC
Created attachment 162350 [details]
screenshot

SUMMARY
Please see the attached screenshot showing two items under "System Settings" section of Shortcuts KCM represented by a generic icon.

EXPECTED RESULT
proper icons instead of generic icons

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.240.0
Qt Version: 6.6.0
Graphics Platform: Wayland
Comment 1 Nate Graham 2023-10-16 17:06:52 UTC
"Custom Shortcuts Service" is a stale/legacy item that's a leftover from when KHotkeys still existed. It can be safely deleted. So let's use this bug report about the "kded6" thing.
Comment 2 Nicolas Fella 2023-10-19 12:00:43 UTC
The problem here is that the shortcuts for "Show System Activity" and "Switch Display" are registered without a proper component name and thus get it from their executable (kded5 in Plasma 5). With 6 they now get kded6, that breaks existing shortcuts.

The solution is to migrate them to a properly named component. https://invent.kde.org/plasma/kscreen/-/merge_requests/126 does that for the display shortcut
Comment 3 Vlad Zahorodnii 2024-01-23 10:37:13 UTC
Git commit 167770b53920ebd3c75ed5c7328ccb651c6b6333 by Vlad Zahorodnii, on behalf of Nicolas Fella.
Committed on 23/01/2024 at 11:35.
Pushed by vladz into branch 'master'.

Define display switcher shortcut via desktop file instead of at runtime

As per https://phabricator.kde.org/T12063 we want to move more towards defining shorcuts via desktop files instead of at runtime, which has several problems

Instead of creating a KActionCollection and QAction, assigning a global shortcut, and connecting to the QAction being triggered define a DBus call to be executed when triggering the shortcut

This fixes several problems:

- The current shortcut is registered under the kded5 component, which not only looks weird in the systemsettigs UI,
it also breaks in Plasma 6 where kded6 is used

- On Wayland the kded module isn't used, so nothing handles the shortcut there currently
Related: bug 479647

M  +0    -1    .kde-ci.yml
M  +0    -1    CMakeLists.txt
M  +0    -1    kded/CMakeLists.txt
M  +1    -18   kded/daemon.cpp
M  +2    -0    osd/CMakeLists.txt
A  +13   -0    osd/org.kde.kscreen.desktop

https://invent.kde.org/plasma/kscreen/-/commit/167770b53920ebd3c75ed5c7328ccb651c6b6333
Comment 4 Bug Janitor Service 2024-01-23 10:43:10 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kscreen/-/merge_requests/270
Comment 5 Vlad Zahorodnii 2024-01-23 10:44:25 UTC
Git commit 0b19db456ff44e759e7ce4786ff84289a896d11e by Vlad Zahorodnii, on behalf of Nicolas Fella.
Committed on 23/01/2024 at 11:40.
Pushed by vladz into branch 'Plasma/6.0'.

Define display switcher shortcut via desktop file instead of at runtime

As per https://phabricator.kde.org/T12063 we want to move more towards defining shorcuts via desktop files instead of at runtime, which has several problems

Instead of creating a KActionCollection and QAction, assigning a global shortcut, and connecting to the QAction being triggered define a DBus call to be executed when triggering the shortcut

This fixes several problems:

- The current shortcut is registered under the kded5 component, which not only looks weird in the systemsettigs UI,
it also breaks in Plasma 6 where kded6 is used

- On Wayland the kded module isn't used, so nothing handles the shortcut there currently
Related: bug 479647
(cherry picked from commit 167770b53920ebd3c75ed5c7328ccb651c6b6333)

M  +0    -1    .kde-ci.yml
M  +0    -1    CMakeLists.txt
M  +0    -1    kded/CMakeLists.txt
M  +1    -19   kded/daemon.cpp
M  +2    -0    osd/CMakeLists.txt
A  +13   -0    osd/org.kde.kscreen.desktop

https://invent.kde.org/plasma/kscreen/-/commit/0b19db456ff44e759e7ce4786ff84289a896d11e
Comment 6 Nicolas Fella 2024-01-25 14:26:28 UTC
https://invent.kde.org/plasma/plasma-systemmonitor/-/merge_requests/248 migrates the system activity shortcut