Bug 475682 - New window overview seems to have minor scaling artifacts
Summary: New window overview seems to have minor scaling artifacts
Status: CONFIRMED
Alias: None
Product: kwin
Classification: Plasma
Component: effects-overview (show other bugs)
Version: git master
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords: qt6
Depends on:
Blocks:
 
Reported: 2023-10-16 06:56 UTC by Quinten Kock
Modified: 2024-02-13 21:21 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of described issue (41.50 KB, image/png)
2023-10-16 06:56 UTC, Quinten Kock
Details
Issue shown on Neon unstable (43.44 KB, image/png)
2024-02-05 00:06 UTC, Quinten Kock
Details
Behaviour after relevant commit (431.43 KB, image/png)
2024-02-13 01:57 UTC, Quinten Kock
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Quinten Kock 2023-10-16 06:56:22 UTC
Created attachment 162344 [details]
Screenshot of described issue

SUMMARY
In the new scaling overview, minor artifacts are visible, likely due to scaling (render window overview at native res -> scale it down to fit)?

In the attachment, one can notice the following issues:
* The close button is inconsistent (The top border looks 'thinner' than the left or right borders)
* The window title text looks kind of odd to me

STEPS TO REPRODUCE
0. (maybe) have a low resolution display?
1. Open new overview

OBSERVED RESULT
Sharp graphics

EXPECTED RESULT
Blurry graphics.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.27.80
KDE Frameworks Version: 5.240.0
Qt Version: 6.5.2

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2023-10-20 16:02:01 UTC
What scale factor are you using?
Comment 2 Quinten Kock 2023-10-20 22:11:03 UTC
Scaling factor is 100%.
Comment 3 fanzhuyifan 2024-02-03 18:40:33 UTC
I think this have been fixed in the recent updates.
Comment 4 Quinten Kock 2024-02-05 00:06:06 UTC
Created attachment 165552 [details]
Issue shown on Neon unstable

Are you sure? I tried Neon unstable 20240201, and the issue still seems to appear. In this picture, it can be seen by the top edge of the close button being 'thinner' than the other edges. That definitely looks like a scaling artifact to me.

Maybe it's only really visible/noticeable on a low res screen, like my 1366x768 laptop?
Comment 5 fanzhuyifan 2024-02-05 01:30:43 UTC
(In reply to Quinten Kock from comment #4)
> Created attachment 165552 [details]
> Issue shown on Neon unstable
> 
> Are you sure? I tried Neon unstable 20240201, and the issue still seems to
> appear. In this picture, it can be seen by the top edge of the close button
> being 'thinner' than the other edges. That definitely looks like a scaling
> artifact to me.
> 
> Maybe it's only really visible/noticeable on a low res screen, like my
> 1366x768 laptop?

Ahh I see your point. On my 1920x1080 screen things seem all right
Comment 6 Bug Janitor Service 2024-02-07 16:30:26 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/5138
Comment 7 Marco Martin 2024-02-08 13:01:32 UTC
Git commit 51fb56773bdf4968646e4e9c5de100a1a62ea234 by Marco Martin.
Committed on 08/02/2024 at 13:01.
Pushed by mart into branch 'master'.

Don't scale WindowHeap in overview mode

when in overview mode, don't scale down WindowHeap, as this
will cause ugly glitches, but resize it down instead.
Still use transforms when it goes in desktop grid mode, at least for now

probably future further refactor can still help things

Before:

![image](/uploads/7ca83e7e9292bd8489faaf76d4c12693/image.png)

After:

![image](/uploads/27b970d056c89486661d6695d09813ff/image.png)

M  +78   -77   src/plugins/overview/qml/main.qml

https://invent.kde.org/plasma/kwin/-/commit/51fb56773bdf4968646e4e9c5de100a1a62ea234
Comment 8 Marco Martin 2024-02-08 13:14:59 UTC
Git commit e824ab00a30ad062657a204af70a60be7fb4c886 by Marco Martin.
Committed on 08/02/2024 at 13:14.
Pushed by mart into branch 'Plasma/6.0'.

Don't scale WindowHeap in overview mode

when in overview mode, don't scale down WindowHeap, as this
will cause ugly glitches, but resize it down instead.
Still use transforms when it goes in desktop grid mode, at least for now

probably future further refactor can still help things

Before:

![image](/uploads/7ca83e7e9292bd8489faaf76d4c12693/image.png)

After:

![image](/uploads/27b970d056c89486661d6695d09813ff/image.png)

M  +78   -77   src/plugins/overview/qml/main.qml

https://invent.kde.org/plasma/kwin/-/commit/e824ab00a30ad062657a204af70a60be7fb4c886
Comment 9 Nate Graham 2024-02-08 17:40:14 UTC
Improved if not completely fixed with https://invent.kde.org/plasma/kwin/-/commit/51fb56773bdf4968646e4e9c5de100a1a62ea234. Quinten, can you test again with KWin that has that commit in it?
Comment 10 Quinten Kock 2024-02-13 01:57:16 UTC
Created attachment 165794 [details]
Behaviour after relevant commit

I tried the most recent Neon Unstable (20240211) which should have the relevant commit. It looks a lot better now, the text doesn't look bad anymore and the close button is now also nice and uniform.

It does however seem like the icons are slightly blurry? Looking at the system settings icon for example, it seems the blue slider bars aren't as sharp as they should be when compared to the same icon elsewhere.

I don't know how WindowHeap handles icon sizes though, so I don't know if this behavior is unexpected, or even fixable.