Bug 475617 - Fixed needed to compile krita under Fedora
Summary: Fixed needed to compile krita under Fedora
Status: REPORTED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-14 17:37 UTC by Dov Grobgeld
Modified: 2023-10-15 10:38 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Dov Grobgeld 2023-10-14 17:37:52 UTC 
SUMMARY

When trying to compile krita commit f35274b26c1eeab410ba7b82d62d156107f6f46f under Fedora 37, I had to apply the following patch to compile:

```
diff --git a/3rdparty_vendor/raqm/CMakeLists.txt b/3rdparty_vendor/raqm/CMakeLists.txt
index 3d42fe186b..6518c83b36 100644
--- a/3rdparty_vendor/raqm/CMakeLists.txt
+++ b/3rdparty_vendor/raqm/CMakeLists.txt
@@ -86,6 +86,7 @@ set(libraqm_SRC
 
 add_library(libraqm STATIC ${libraqm_SRC})
 set_property(TARGET libraqm PROPERTY C_STANDARD 99)
+set_property(TARGET libraqm PROPERTY POSITION_INDEPENDENT_CODE ON)
 
 target_include_directories(libraqm INTERFACE ${libraqm_src_SOURCE_DIR}/src)
 target_include_directories(libraqm PUBLIC ${CMAKE_CURRENT_BINARY_DIR})
```

Meta question:

- Should I have opened a merge request?
- Should I attach the patch as an attachment?
Comment 1 Halla Rempt 2023-10-15 10:38:33 UTC 
A merge request makes things really easy :-)