SUMMARY When trying to compile krita commit f35274b26c1eeab410ba7b82d62d156107f6f46f under Fedora 37, I had to apply the following patch to compile: ``` diff --git a/3rdparty_vendor/raqm/CMakeLists.txt b/3rdparty_vendor/raqm/CMakeLists.txt index 3d42fe186b..6518c83b36 100644 --- a/3rdparty_vendor/raqm/CMakeLists.txt +++ b/3rdparty_vendor/raqm/CMakeLists.txt @@ -86,6 +86,7 @@ set(libraqm_SRC add_library(libraqm STATIC ${libraqm_SRC}) set_property(TARGET libraqm PROPERTY C_STANDARD 99) +set_property(TARGET libraqm PROPERTY POSITION_INDEPENDENT_CODE ON) target_include_directories(libraqm INTERFACE ${libraqm_src_SOURCE_DIR}/src) target_include_directories(libraqm PUBLIC ${CMAKE_CURRENT_BINARY_DIR}) ``` Meta question: - Should I have opened a merge request? - Should I attach the patch as an attachment?
A merge request makes things really easy :-)
This patch is not needed anymore since we anavbled PIC in the entire Krita lately: https://invent.kde.org/graphics/krita/-/commit/0d508c09637c361aa16658f371961e0bb48aeec2
Git commit e62c63696b3967e5f390592fa3c7a6064ffee344 by Dmitry Kazakov. Committed on 22/04/2025 at 16:38. Pushed by dkazakov into branch 'krita/5.2'. Enable PIC for our local raqm builds M +1 -0 3rdparty_vendor/raqm/CMakeLists.txt https://invent.kde.org/graphics/krita/-/commit/e62c63696b3967e5f390592fa3c7a6064ffee344