Bug 475557 - layer styles do not take in to account content beyond canvas boundary when adding them, but do so when document is reopened.
Summary: layer styles do not take in to account content beyond canvas boundary when ad...
Status: RESOLVED WORKSFORME
Alias: None
Product: krita
Classification: Applications
Component: layer styles (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-13 09:44 UTC by Raghavendra kamath
Modified: 2023-10-18 14:38 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Raghavendra kamath 2023-10-13 09:44:20 UTC
SUMMARY
When a user adds a layer style to a layer containing data beyond canvas boundary, Krita doesn't only takes into account the data that appears on canvas. but as soon as you close and reopen the file it applies the layer style to whole content even which is beyond the canvas.

And for layer style I believe it is better to take layer content boundary rather than canvas boundary, as far as I know this is how it works in photoshop. People can move layer to the edges and have some content of the layer go beyond the canvas boundary. 

The issue arises only when adding a layer style, once the document is saved and reopened the layer style works as expected. 



STEPS TO REPRODUCE
1. Open a new document add some square shapes at the edge of the boundary
2. move these square beyond the canvas boundary a bit
3. Add drop dhadow layer style, you will notice the drop shadow appears for the content that is inside the canvas boundary

OBSERVED RESULT
When adding layer style content outside the canvas boundary is ignored

EXPECTED RESULT
Layer boundary instead of canvas boundary should be taken in to account when adding layer style. 

This was reported on KA by a user, you can see the screenshot showing the issue of cut off drop shadow in the topic - https://krita-artists.org/t/drop-shadow-gap-on-edge-of-image-if-a-layers-pixel-data-is-off-canvas/75469
Comment 1 wolthera 2023-10-18 11:03:40 UTC
There must be something weird going on, because I cannot reproduce this for Krita Version: 5.3.0-prealpha (git f8a95bc), Qt version compiled: 5.15.11

Can you create a file that shows the problem? Or maybe a video? I've tried the reproduction steps at the least 5 times...
Comment 2 Raghavendra kamath 2023-10-18 14:38:58 UTC
Hmm. I couldn't reproduce in 5.2 and also in 5.3 strange. We can close this for now. I will keep an eye on this if we encounter it again we will file a report again or reopen this later. The user too can't reproduce it.