Bug 475509 - The file "FFmpeg.exe" is missing in Krita's "krita-x64-5.2.0-setup.exe"
Summary: The file "FFmpeg.exe" is missing in Krita's "krita-x64-5.2.0-setup.exe"
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Animation (other bugs)
Version First Reported In: 5.2.0
Platform: Microsoft Windows Microsoft Windows
: NOR major
Target Milestone: ---
Assignee: Alvin Wong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-12 09:52 UTC by Michael Strothotte
Modified: 2023-10-12 12:05 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Strothotte 2023-10-12 09:52:34 UTC
SUMMARY: The file "FFmpeg.exe" is missing from the setup file of Krita 5.2.0 "krita-x64-5.2.0-setup.exe". The implications of this should be self-explanatory. 

################################################################################

Based on this report from @Konstrukto: 

https://krita-artists.org/t/krita-5-2-is-released/75820/20?u=michelist 
Quote: 
"I’m not sure if this is connected but on the release client as well as the current version the installation didn’t generate the ffmpeg file for me.
@Michelist kindly provided one for me, so I am covered, however there may be others experiencing this issue
Also good to note because someone may not usually animate, and may discover this later on."

I just unpacked the file "krita-x64-5.2.0-setup.exe" and found that the file "FFmpeg.exe" is missing in the folder "bin". 
In the archive of the portable version, however, the file "FFmpeg.exe" is present in the folder "bin", so there is no need for action with the portable version. 

Since I only work with portable versions of Krita myself, I didn't notice this, and I hadn't investigated the missing of the file "FFmpeg.exe" more deeply during the RC phase, when @Konstrukto reported the same error there. Because of his statement: 

"Unfortunately I can't render my current animations with the old FFmpeg on this krita version ...", 

I thought he had deleted the new FFmpeg while handling the old FFmpeg.
I should have realized this at the time @Konstrukto reported the missing file during the RC phase, that this could not have been the case. 

################################################################################

Steps to reproduce this: 
Either install the setup version of Krita 5.2.0 and then not find the file "FFmpeg.exe" in the installation subfolder →

"c:\Program Files\Krita (x64)\bin\", 

or extract the file → 

"krita-x64-5.2.0-setup.exe", 

for example, with the software "Universal Extractor", to a folder of your choice and then not find the file "FFmpeg.exe" in the extracted subfolder "bin" of the selected extraction folder. 

Expected result: The file "FFmpeg.exe" would be located in the "krita-x64-5.2.0-setup.exe" and thus could be installed with in the folder "c:\Program Files\Krita (x64)\bin\". 

This affects every version of Windows, so I spare you the data of my computer.
Without knowing your rating criteria, I have set the severity of the error to "Major", please adjust this if necessary.

Regards
Michelist

ADDITIONAL INFORMATION:
Here are the related posts from the Release Candidate topic (just for completeness, there is no special information hidden in them): 

https://krita-artists.org/t/krita-5-2-release-candidate-is-out-please-help-us-in-another-round-of-testing/74137/95?u=michelist

https://krita-artists.org/t/krita-5-2-release-candidate-is-out-please-help-us-in-another-round-of-testing/74137/97?u=michelist

https://krita-artists.org/t/krita-5-2-release-candidate-is-out-please-help-us-in-another-round-of-testing/74137/98?u=michelist

https://krita-artists.org/t/krita-5-2-release-candidate-is-out-please-help-us-in-another-round-of-testing/74137/99?u=michelist

https://krita-artists.org/t/krita-5-2-release-candidate-is-out-please-help-us-in-another-round-of-testing/74137/101?u=michelist

https://krita-artists.org/t/krita-5-2-release-candidate-is-out-please-help-us-in-another-round-of-testing/74137/102?u=michelist

https://krita-artists.org/t/krita-5-2-release-candidate-is-out-please-help-us-in-another-round-of-testing/74137/103?u=michelist
Comment 1 konstrukto 2023-10-12 09:58:53 UTC
From @Konstrukto: @Michelist stated this well, I can confirm that this was also my experience.
Comment 2 Alvin Wong 2023-10-12 12:05:28 UTC
Git commit debc815bd51bef6c0f2309a9653fbf5dd071c70a by Alvin Wong.
Committed on 12/10/2023 at 14:00.
Pushed by alvinwong into branch 'master'.

win/installer: Fix ffmpeg being excluded

Remove remnants of the long-obsolete optional ffmpeg component in the
installer which explicitly excludes `ffmpeg.exe`.

FFmpeg is now treated as a typical required component.

M  +0    -12   packaging/windows/installer/MakeInstallerNsis.cmake.in
M  +1    -15   packaging/windows/installer/installer_krita.nsi
M  +0    -3    packaging/windows/installer/translations/English.nsh
M  +0    -3    packaging/windows/installer/translations/SimpChinese.nsh
M  +0    -3    packaging/windows/installer/translations/TradChinese.nsh

https://invent.kde.org/graphics/krita/-/commit/debc815bd51bef6c0f2309a9653fbf5dd071c70a
Comment 3 Alvin Wong 2023-10-12 12:05:59 UTC
Git commit 68389f217856f20662db43db894f86943551e4ab by Alvin Wong.
Committed on 12/10/2023 at 14:05.
Pushed by alvinwong into branch 'krita/5.2'.

win/installer: Fix ffmpeg being excluded

Remove remnants of the long-obsolete optional ffmpeg component in the
installer which explicitly excludes `ffmpeg.exe`.

FFmpeg is now treated as a typical required component.
(cherry picked from commit debc815bd51bef6c0f2309a9653fbf5dd071c70a)

M  +0    -12   packaging/windows/installer/MakeInstallerNsis.cmake.in
M  +1    -15   packaging/windows/installer/installer_krita.nsi
M  +0    -3    packaging/windows/installer/translations/English.nsh
M  +0    -3    packaging/windows/installer/translations/SimpChinese.nsh
M  +0    -3    packaging/windows/installer/translations/TradChinese.nsh

https://invent.kde.org/graphics/krita/-/commit/68389f217856f20662db43db894f86943551e4ab