Created attachment 162094 [details] Confirmation dialogue. This should not be able to be disabled SUMMARY If you have Dolphin configured to delete items without confirmation, then this will also happen when files can't be moved to trash because of space constraints. This is unpredictable, because the user might not know that there isn't enough space in the trash. While the user will expect the item to be in the trash, it will instead instantly delete with no warning or indication of what's happened. STEPS TO REPRODUCE 1. Configure Dolphin to skip the confirmation when deleting files 2. Reduce the size of the trash (or have little space left in it) 3. Move a large item to the trash OBSERVED RESULT The item is permanently (and silently) deleted EXPECTED RESULT A warning appears saying that the item can't be moved to trash because of its size ADDITIONAL INFORMATION I'll clarify that I think that having confirmations off is absolutely valid for many use cases. It can be annoying to have an extra step each time you do shift+delete. However, it only works when there is intention behind the action, which there isn't when it automatically does it out of space limitations. The setting should only affect deletions explicitly triggered by user action.
KDE Plasma Version: 5.27.8 KDE Frameworks Version: 5.110.0 My Dolphin is also 23.08.1 , so I guess behavior should be matching, but I get the following warning: "The trash is full. Empty it or remove items manually." Given the Dolphin version match, maybe there's a mismatch for KIO where thrash handling actually happens? I can confidently say though that I can't reproduce, and the behavior I'm seeing is safe.
Hi! Thank you for triaging this and responding! I wanted to get back much sooner, but things got in the way. I appreciate you taking the time! As far as I can tell both the message you got¹ and the one I get² exists in the code and both are provided by KIO, though I don't know what makes it trigger one or the other. It's interesting that there are multiple behaviours, but nevertheless I can verify that the problem persists even now on Frameworks 6.1.0 with Dolphin 24.02.2. It's been this way for well over a year now³, so probably the differences aren't some version mismatch. Maybe someone more knowledgeable can explain. ¹ https://invent.kde.org/frameworks/kio/-/blob/master/src/kioworkers/trash/trashimpl.cpp#L1328 ² https://invent.kde.org/frameworks/kio/-/blob/master/src/widgets/widgetsaskuseractionhandler.cpp#L256-261 ³ https://invent.kde.org/frameworks/kio/-/merge_requests/1005
Recommending using the "Permalink" button when linking source code files as the links containing "master" will just point to whatever is the latest, so they will become stale over time as files are changed and lines are drifting around if not completely changed or removed. Looking at the code, the key will be the "Configure Dolphin to skip the confirmation when deleting files" step, and the logical problem can be mostly understood here: https://invent.kde.org/frameworks/kio/-/blob/a360462d5290200b27d874d1cb3895336942d55b/src/widgets/widgetsaskuseractionhandler.cpp#L304 Apparently I made the mistake of understanding deleting as something like pressing the Delete button which should trash by default, but it's actually file delete in this case. The "Reduce the size of the trash" step breaks reproduction though, however I can't really see why isn't `(util.usage(partitionSize + additionalSize)) >= percent` evaluating to true in that case. With that, I can confirm this to be an undesired data loss problem, even though I personally consider only trashing to be safe without confirmation, and even that is annoying to do accidentally as there isn't an interface for reverting recent trashing operations, the user has to dig. Reproducer: 1. Uncheck the "Deleting files or folders" confirmation setting. 2. Ensure the trash isn't full already (Beware: Just setting trash limit to 0.01% to make it full already doesn't work here) 3. Create a large test file: `truncate -s 32G test.file` (modify size as needed to make sure it doesn't fit into the configured trash size limit) 4. Attempt to trash the test file 5. Observe the trashing operation being promoted to deletion which then gets automatically confirmed Issue is CONFIRMED, and it seems to be a problem in KIO, not in Dolphin, should affect other products too. Can't reproduce in Krusader though, this time trashing is just hanging, but that's a matter belonging to Bug 486299 . Suggesting bumping up Importance as this is a data loss concern.