Bug 475172 - Wrong file name in title bar
Summary: Wrong file name in title bar
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 5.2.0-rc1
Platform: Debian stable Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-03 12:42 UTC by Rebecca Breu
Modified: 2023-10-20 16:03 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshots of all three steps (309.93 KB, image/jpeg)
2023-10-03 12:42 UTC, Rebecca Breu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rebecca Breu 2023-10-03 12:42:20 UTC
Created attachment 162051 [details]
Screenshots of all three steps

On 5.2 rc1, subwindows enabled, all files in fullscreen. I’m noticing a weirdness with the title bar that I don’t understand. I start Krita and open my first file called comic031.kra. The title bar looks as it did in previous versions, see also attached screenshots:

(1.4 GiB) - [comic031.kra] — Krita

I open a second file called comic033.kra while the first file is still open, now I get the filename displayed twice.

comic033.kra (714.5 MiB) - [comic033.kra] — Krita

If I reproduce this step in 5.1, I still only have the name in brackets, not the name at the beginning of the line.

Now if I switch back to the first image, I get two *different* file names displayed, plus what seems like the file size of the other image:

comic033.kra (714.5 MiB) - [comic031.kra] — Krita

Again, in 5.1 I only get the second filename and the correct size.

Both documents have document titles set, comic031 and comic033 respectively.

If I keep opening more files, they all get comic033 as second file name, and that image’s size. Trying out other orders of opening the files, I think Krita just really likes the alphabetically last one.

Why is it trying to display two file names in the first place? I can’t see what use that would be. I can imagine displaying the document title could be useful, which my files have set but those don’t have the .kra ending.

This is a somewhat scary problem, because I feared for a moment that I was overwriting files I didn't want to overwrite.


Krita

 Version: 5.2.0-rc1 (git 3323e4e)
 Hidpi: false

Qt

  Version (compiled): 5.15.7
  Version (loaded): 5.15.7

OS Information

  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: linux
  Kernel Version: 5.10.0-25-amd64
  Pretty Productname: Debian GNU/Linux 11 (bullseye)
  Product Type: debian
  Product Version: 11
  Desktop: GNOME
  Appimage build: Yes

Locale

  Languages: en_US, en, en_Latn_US, en, en_US, en_Latn_US
  C locale: en_GB.UTF-8
  QLocale current: en
  QLocale system: en
  QTextCodec for locale: UTF-8

OpenGL Info
 
  Vendor:  "Intel" 
  Renderer:  "Mesa Intel(R) HD Graphics 630 (KBL GT2)" 
  Driver version:  "4.6 (Core Profile) Mesa 20.3.5" 
  Shading language:  "4.60" 
  Requested format:  QSurfaceFormat(version 3.3, options QFlags<QSurfaceFormat::FormatOption>(), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 0, colorSpace QSurfaceFormat::DefaultColorSpace, profile  QSurfaceFormat::CompatibilityProfile) 
  Current format:  QSurfaceFormat(version 4.6, options QFlags<QSurfaceFormat::FormatOption>(), depthBufferSize 24, redBufferSize 8, greenBufferSize 8, blueBufferSize 8, alphaBufferSize 8, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 0, colorSpace QSurfaceFormat::DefaultColorSpace, profile  QSurfaceFormat::CoreProfile) 
  GL version: 4.6 
  Supports deprecated functions false 
  Is OpenGL ES: false 
  supportsBufferMapping: true 
  supportsBufferInvalidation: true 
  forceDisableTextureBuffers: false 
  Extensions: 
     GL_ARB_get_texture_sub_image 
     GL_ARB_texture_multisample 
     GL_ARB_shader_group_vote 
     GL_ARB_shader_draw_parameters 
     GL_ATI_texture_float 
     GL_AMD_conservative_depth 
     GL_ARB_texture_non_power_of_two 
     GL_ARB_ES3_compatibility 
     GL_ARB_occlusion_query2 
     GL_ARB_texture_compression_rgtc 
     GL_EXT_texture_swizzle 
     GL_AMD_texture_texture4 
     GL_ARB_vertex_shader 
     GL_KHR_robust_buffer_access_behavior 
     GL_ARB_depth_buffer_float 
     GL_KHR_no_error 
     GL_ARB_shading_language_packing 
     GL_ARB_framebuffer_no_attachments 
     GL_ARB_shader_clock 
     GL_ARB_half_float_pixel 
     GL_ARB_vertex_array_object 
     GL_ARB_gpu_shader_int64 
     GL_ARB_robustness 
     GL_NV_conditional_render 
     GL_ARB_shader_texture_image_samples 
     GL_ARB_shader_precision 
     GL_ARB_shader_atomic_counter_ops 
     GL_ARB_texture_storage_multisample 
     GL_ARB_transform_feedback3 
     GL_ARB_ES3_1_compatibility 
     GL_ARB_texture_swizzle 
     GL_ARB_draw_buffers_blend 
     GL_S3_s3tc 
     GL_ARB_texture_buffer_range 
     GL_ARB_draw_buffers 
     GL_ARB_draw_indirect 
     GL_ARB_fragment_shader_interlock 
     GL_ARB_shader_storage_buffer_object 
     GL_INTEL_shader_atomic_float_minmax 
     GL_EXT_texture_compression_s3tc 
     GL_EXT_transform_feedback 
     GL_ARB_texture_mirror_clamp_to_edge 
     GL_EXT_shader_samples_identical 
     GL_ARB_shader_stencil_export 
     GL_ARB_multi_bind 
     GL_ARB_sampler_objects 
     GL_ARB_derivative_control 
     GL_ARB_pipeline_statistics_query 
     GL_EXT_texture_compression_rgtc 
     GL_ARB_map_buffer_range 
     GL_ARB_copy_image 
     GL_ARB_transform_feedback_overflow_query 
     GL_NV_compute_shader_derivatives 
     GL_ARB_spirv_extensions 
     GL_ARB_framebuffer_sRGB 
     GL_ARB_texture_rgb10_a2ui 
     GL_MESA_texture_signed_rgba 
     GL_ARB_gpu_shader_fp64 
     GL_KHR_blend_equation_advanced 
     GL_EXT_texture_sRGB_R8 
     GL_EXT_vertex_array_bgra 
     GL_ARB_fragment_coord_conventions 
     GL_ARB_seamless_cube_map 
     GL_ARB_base_instance 
     GL_ARB_draw_elements_base_vertex 
     GL_ARB_framebuffer_object 
     GL_EXT_texture_sRGB_decode 
     GL_EXT_texture_snorm 
     GL_AMD_multi_draw_indirect 
     GL_AMD_seamless_cubemap_per_texture 
     GL_EXT_semaphore_fd 
     GL_AMD_draw_buffers_blend 
     GL_3DFX_texture_compression_FXT1 
     GL_EXT_shader_integer_mix 
     GL_KHR_texture_compression_astc_ldr 
     GL_ARB_gpu_shader5 
     GL_EXT_framebuffer_blit 
     GL_EXT_draw_instanced 
     GL_ARB_sync 
     GL_ARB_stencil_texturing 
     GL_ARB_shader_ballot 
     GL_ARB_conservative_depth 
     GL_ARB_uniform_buffer_object 
     GL_ARB_texture_filter_anisotropic 
     GL_EXT_texture_array 
     GL_ARB_shading_language_include 
     GL_ARB_compute_variable_group_size 
     GL_AMD_vertex_shader_viewport_index 
     GL_IBM_multimode_draw_arrays 
     GL_ARB_cull_distance 
     GL_EXT_abgr 
     GL_ARB_half_float_vertex 
     GL_ARB_enhanced_layouts 
     GL_AMD_pinned_memory 
     GL_ARB_shader_subroutine 
     GL_ARB_direct_state_access 
     GL_ARB_texture_query_lod 
     GL_EXT_framebuffer_object 
     GL_AMD_shader_stencil_export 
     GL_ARB_texture_query_levels 
     GL_EXT_pixel_buffer_object 
     GL_EXT_provoking_vertex 
     GL_INTEL_performance_query 
     GL_ATI_blend_equation_separate 
     GL_EXT_packed_depth_stencil 
     GL_EXT_blend_equation_separate 
     GL_ARB_texture_cube_map_array 
     GL_ARB_texture_buffer_object 
     GL_EXT_polygon_offset_clamp 
     GL_NV_fragment_shader_interlock 
     GL_EXT_texture_integer 
     GL_ARB_separate_shader_objects 
     GL_NV_copy_image 
     GL_ARB_point_sprite 
     GL_ARB_texture_view 
     GL_EXT_framebuffer_sRGB 
     GL_ARB_blend_func_extended 
     GL_EXT_shader_framebuffer_fetch 
     GL_ARB_gl_spirv 
     GL_ARB_polygon_offset_clamp 
     GL_ARB_explicit_attrib_location 
     GL_ARB_get_program_binary 
     GL_INTEL_blackhole_render 
     GL_KHR_blend_equation_advanced_coherent 
     GL_ARB_shader_objects 
     GL_ARB_shader_bit_encoding 
     GL_ARB_conditional_render_inverted 
     GL_ARB_clear_buffer_object 
     GL_ARB_ES2_compatibility 
     GL_AMD_vertex_shader_layer 
     GL_ARB_shader_texture_lod 
     GL_EXT_timer_query 
     GL_ARB_shader_atomic_counters 
     GL_EXT_semaphore 
     GL_ARB_shading_language_420pack 
     GL_ARB_parallel_shader_compile 
     GL_ARB_clear_texture 
     GL_ARB_timer_query 
     GL_MESA_shader_integer_functions 
     GL_ARB_shader_image_size 
     GL_AMD_query_buffer_object 
     GL_ARB_vertex_type_2_10_10_10_rev 
     GL_ARB_explicit_uniform_location 
     GL_ARB_arrays_of_arrays 
     GL_ARB_compressed_texture_pixel_storage 
     GL_ARB_robust_buffer_access_behavior 
     GL_ARB_internalformat_query 
     GL_EXT_EGL_image_storage 
     GL_KHR_texture_compression_astc_sliced_3d 
     GL_MESA_framebuffer_flip_y 
     GL_ARB_indirect_parameters 
     GL_ARB_instanced_arrays 
     GL_ARB_clip_control 
     GL_ARB_provoking_vertex 
     GL_ARB_texture_barrier 
     GL_EXT_texture_filter_anisotropic 
     GL_EXT_demote_to_helper_invocation 
     GL_KHR_debug 
     GL_ARB_texture_float 
     GL_ARB_buffer_storage 
     GL_EXT_draw_buffers2 
     GL_ARB_program_interface_query 
     GL_ARB_vertex_array_bgra 
     GL_ARB_viewport_array 
     GL_AMD_shader_trinary_minmax 
     GL_EXT_texture_sRGB 
     GL_OES_EGL_image 
     GL_MESA_pack_invert 
     GL_AMD_performance_monitor 
     GL_ARB_vertex_attrib_binding 
     GL_EXT_EGL_sync 
     GL_ARB_internalformat_query2 
     GL_ARB_copy_buffer 
     GL_INTEL_shader_integer_functions2 
     GL_ARB_texture_stencil8 
     GL_EXT_vertex_attrib_64bit 
     GL_KHR_robustness 
     GL_ARB_transform_feedback2 
     GL_ARB_multi_draw_indirect 
     GL_ARB_map_buffer_alignment 
     GL_ARB_texture_gather 
     GL_ARB_transform_feedback_instanced 
     GL_ARB_depth_clamp 
     GL_ARB_draw_instanced 
     GL_ARB_texture_rectangle 
     GL_ARB_compute_shader 
     GL_ARB_vertex_buffer_object 
     GL_ARB_texture_rg 
     GL_ARB_tessellation_shader 
     GL_ARB_pixel_buffer_object 
     GL_EXT_packed_float 
     GL_ANGLE_texture_compression_dxt5 
     GL_ARB_debug_output 
     GL_ARB_fragment_layer_viewport 
     GL_AMD_depth_clamp_separate 
     GL_EXT_texture_shadow_lod 
     GL_AMD_gpu_shader_int64 
     GL_ARB_vertex_type_10f_11f_11f_rev 
     GL_KHR_parallel_shader_compile 
     GL_KHR_context_flush_control 
     GL_NV_packed_depth_stencil 
     GL_ANGLE_texture_compression_dxt3 
     GL_EXT_shader_framebuffer_fetch_non_coherent 
     GL_ARB_post_depth_coverage 
     GL_ARB_texture_storage 
     GL_ARB_vertex_attrib_64bit 
     GL_EXT_framebuffer_multisample_blit_scaled 
     GL_ARB_fragment_shader 
     GL_INTEL_conservative_rasterization 
     GL_ARB_query_buffer_object 
     GL_ARB_shader_viewport_layer_array 
     GL_EXT_texture_shared_exponent 
     GL_ARB_texture_buffer_object_rgb32 
     GL_EXT_texture_compression_dxt1 
     GL_ARB_texture_compression_bptc 
     GL_ARB_shader_image_load_store 
     GL_ARB_invalidate_subdata 
     GL_NV_texture_barrier 
     GL_EXT_framebuffer_multisample 
     GL_ARB_sample_shading 
     GL_NV_depth_clamp 
     GL_ARB_ES3_2_compatibility 
     GL_ARB_seamless_cubemap_per_texture 

QPA OpenGL Detection Info 
  supportsDesktopGL: true 
  supportsOpenGLES: true 
  isQtPreferOpenGLES: false 
  Detected renderers: 
    (Supported) Mesa Intel(R) HD Graphics 630 (KBL GT2) (OpenGL ES 3.2 Mesa 20.3.5) 
    (Supported) Mesa Intel(R) HD Graphics 630 (KBL GT2) (4.6 (Core Profile) Mesa 20.3.5)  

useBufferInvalidation (config option): false


Hardware Information

  GPU Acceleration: auto
  Memory: 15741 Mb
  Number of Cores: 4
  Swap Location: /tmp
  Built for: sse2
  Base instruction set: fma3+avx2
  Supported instruction sets: fma3+avx2 avx2 fma3+avx avx fma4 fma3+sse4.2 sse4.2 sse4.1 ssse3 sse3 sse2 

Current Settings

  Current Swap Location: /tmp
  Current Swap Location writable: true
  Undo Enabled: true
  Undo Stack Limit: 100
  Use OpenGL: true
  Use OpenGL Texture Buffer: true
  Disable Vector Optimizations: false
  Disable AVX Optimizations: false
  Canvas State: OPENGL_SUCCESS
  Autosave Interval: 300
  Use Backup Files: true
  Number of Backups Kept: 1
  Backup File Suffix: ~
  Backup Location: Same Folder as the File
  Backup Location writable: false
  Resource Location: /home/rbreu/.local/share/krita
  Use Win8 Pointer Input: false
  Use RightMiddleTabletButton Workaround: false
  Levels of Detail Enabled: true
  Use Zip64: false


Loaded Python Plugins
	export_scaled
	python_reference
	colorspace
	comics_project_management_tools
	documenttools
	exportlayers
	filtermanager
	lastdocumentsdocker
	mixer_slider_docker
	plugin_importer
	quick_settings_docker
	scripter
	tenbrushes
	tenscripts


Display Information
Number of screens: 1
	Screen: 0
		Name: eDP-1
		Depth: 24
		Scale: 1
		Physical DPI210.32
		Logical DPI192
		Physical Size: 309, 174
		Position: 0, 0
		Resolution in pixels: 2560x1440
		Manufacturer: AU Optronics
		Model: AUO1536
		Refresh Rate: 119.986
		Serial Number:
Comment 1 Bug Janitor Service 2023-10-06 09:08:05 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/1955
Comment 2 Dmitry Kazakov 2023-10-20 15:48:06 UTC
Git commit 8f286521ed95e83ac8740a6dd96e123aee759c58 by Dmitry Kazakov.
Committed on 20/10/2023 at 17:47.
Pushed by dkazakov into branch 'master'.

Rely to Qt's internal mechanism of setting window title

Now our forked version of Qt has an option to enable showing
document name in the main window title all the time
(QMdiArea::AlwaysShowSubwindowNameInTitleBar), so we don't need
our own implementation of it.

M  +13   -3    CMakeLists.txt
A  +4    -0    config-qmdiarea-always-show-subwindow-title.h.cmake
M  +18   -8    libs/ui/KisDocument.cpp
M  +3    -8    libs/ui/KisDocument.h
M  +30   -78   libs/ui/KisMainWindow.cpp
M  +2    -10   libs/ui/KisMainWindow.h
M  +37   -9    libs/ui/KisView.cpp
M  +2    -2    libs/ui/KisView.h
M  +0    -9    libs/ui/KisViewManager.cpp
M  +0    -2    libs/ui/kis_statusbar.cc
M  +0    -4    libs/ui/kis_statusbar.h

https://invent.kde.org/graphics/krita/-/commit/8f286521ed95e83ac8740a6dd96e123aee759c58
Comment 3 Dmitry Kazakov 2023-10-20 16:03:00 UTC
Git commit 6aed967f9e7024e38e7bc5d59da8983987cb3d6a by Dmitry Kazakov.
Committed on 20/10/2023 at 17:49.
Pushed by dkazakov into branch 'krita/5.2'.

Rely to Qt's internal mechanism of setting window title

Now our forked version of Qt has an option to enable showing
document name in the main window title all the time
(QMdiArea::AlwaysShowSubwindowNameInTitleBar), so we don't need
our own implementation of it.

# Conflicts:
#	libs/ui/KisMainWindow.cpp

M  +13   -3    CMakeLists.txt
A  +4    -0    config-qmdiarea-always-show-subwindow-title.h.cmake
M  +18   -8    libs/ui/KisDocument.cpp
M  +3    -8    libs/ui/KisDocument.h
M  +30   -78   libs/ui/KisMainWindow.cpp
M  +2    -10   libs/ui/KisMainWindow.h
M  +37   -9    libs/ui/KisView.cpp
M  +2    -2    libs/ui/KisView.h
M  +0    -9    libs/ui/KisViewManager.cpp
M  +0    -2    libs/ui/kis_statusbar.cc
M  +0    -4    libs/ui/kis_statusbar.h

https://invent.kde.org/graphics/krita/-/commit/6aed967f9e7024e38e7bc5d59da8983987cb3d6a